util: random_string is now more entropic #29312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizeof(char*) is going to be 8 on a 64-bit system, not the length of the string. Before, only strings of integer values [0-6] were being generated. Also switched to C++ constructs for simplicity.
sshane
reviewed
Aug 10, 2023
sshane
reviewed
Aug 11, 2023
sshane
changed the title
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Aug 11, 2023
* random_string now returns a significantly higher entropy random string sizeof(char*) is going to be 8 on a 64-bit system, not the length of the string. Before, only strings of integer values [0-6] were being generated. Also switched to C++ constructs for simplicity. * Update common/util.cc * maintain repo style --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeof(char*) is going to be 8 on a 64-bit system, not the length of the string. Before, only strings of integer values [0-6] were being generated. Also switched to C++ constructs for simplicity.