Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Add missing FW versions for Kia Forte 2023 #30761

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

sunnyhaibin
Copy link
Contributor

Add firmware versions for the 2023 Kia Forte.

Dongle ID: 753639a1c1872d8c

Thanks to the community 2023 Kia Forte owner byron_88676 (Discord).

@github-actions github-actions bot added car vehicle-specific hyundai labels Dec 16, 2023
@sshane
Copy link
Contributor

sshane commented Dec 21, 2023

@sunnyhaibin same thing here #30759 (comment)

@ahr2435tech
Copy link

This does not work on my 2023 Kia Forte. I get car unrecognized message

@sshane
Copy link
Contributor

sshane commented Jan 31, 2024

@ahr2435tech what is your dongle id?

@sshane
Copy link
Contributor

sshane commented Feb 8, 2024

#31254 also fuzzy fingerprints this dongle!

Copy link
Contributor

github-actions bot commented Feb 8, 2024

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

@@ -991,11 +992,13 @@
(Ecu.abs, 0x7d1, None): [
b'\xf1\x816VGRAH00018.ELF\xf1\x00\x00\x00\x00\x00\x00\x00',
b'\xf1\x8758900-M7AB0 \xf1\x816VQRAD00127.ELF\xf1\x00\x00\x00\x00\x00\x00\x00',
b'\xf1\x00\x00\x00\x00\x00\x00\x00',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the ABS ECU, it's obvious it's not responding in a format we expect. That, or add the query to get it properly which requires some prodding on this vehicle. Leaving for now

@sshane
Copy link
Contributor

sshane commented Feb 8, 2024

Dongle, platform, VIN Name from VIN 🆚 CarInfo Segments Bad seg tags Good seg tags
753639a1c1872d8c
KIA FORTE E 2018 & GT 2021
3KPF54AD6........
KIA Forte 2023 🆚
Kia Forte 2023
23 routes, 522 segments - all lat active: 15
- no input all lat active: 6

@sshane sshane changed the title HKG: Add FW versions for Kia Forte 2023 HKG: Add missing FW versions for Kia Forte 2023 Feb 8, 2024
@sshane sshane merged commit fabb739 into commaai:master Feb 8, 2024
28 checks passed
@vesenwa
Copy link

vesenwa commented Mar 14, 2024

Same unit worked in crv 2020. Tried forte 2023, guess fw issue. Error - can error, check connections.

dongle id bbc520c51098bebc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants