Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: relative cache and enable --warn=all #30847

Closed
wants to merge 0 commits into from

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Dec 24, 2023

Description [](A description of the bug and the fix. Also link any relevant issues.)
For #30161 and #29500, currently using relative path for building everywhere, added GHA unit test to see if the name of the workspace appears in the build log of GHA. The caching time should be the same as before.

Update 12/26/2023:
Changed GHA unittest to Python unittest. Fix violations when enable --warn=all.

@bongbui321
Copy link
Contributor Author

Currently, waiting for submodule PRs to merge then can merge these updates in openpilot

@bongbui321 bongbui321 changed the title CI: building and caching based on relative path rather than abspath CI: relative cache and enable --warn=all #29500, #30161 Dec 26, 2023
@bongbui321 bongbui321 changed the title CI: relative cache and enable --warn=all #29500, #30161 CI: relative cache and enable --warn=all https://github.com/commaai/openpilot/issues/30161 https://github.com/commaai/openpilot/issues/29500 Dec 26, 2023
@bongbui321 bongbui321 changed the title CI: relative cache and enable --warn=all https://github.com/commaai/openpilot/issues/30161 https://github.com/commaai/openpilot/issues/29500 CI: relative cache and enable --warn=all Dec 26, 2023
@bongbui321 bongbui321 closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant