Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-up-on-retry Openpilot on GHA runners (WIP) #30873

Closed
wants to merge 8 commits into from

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Dec 31, 2023

For #30706.

Currently, caching the apt packages and dependencies on GHA runners chops off 10~15s on setup with retry on docs.yaml:
52s on setup
45s on setup
However, it sometimes take the same amount as caching from ghrc within bounds of 5s. Most slow down is from extracting the tar and downloading the cache.

I have also tested with caching docker image with local and new experimental gha cache, but most of the time is from loading or pulling the image, and they are significantly slower (around 30s to 1 min)

Then the feasible good way to shorten this is to cut off the dependencies

@bongbui321 bongbui321 marked this pull request as draft December 31, 2023 04:03
@bongbui321 bongbui321 changed the title Set Up Openpilot on GHA runners (WIP) Set-up-on-retry Openpilot on GHA runners (WIP) Dec 31, 2023
@bongbui321 bongbui321 marked this pull request as ready for review December 31, 2023 04:12
@bongbui321 bongbui321 marked this pull request as draft December 31, 2023 17:35
@adeebshihadeh
Copy link
Contributor

The base Ubuntu 20.04 Docker image is only ~70MB, and our image is a few GB. I agree we've gotta cut down on the dependencies, but I suspect there's still a good amount we're wasting.

For example, are there any dependencies we need for building/installing all the Python dependencies that we can remove once it's all setup?

@adeebshihadeh
Copy link
Contributor

Any luck with slimming down the image?

@bongbui321
Copy link
Contributor Author

I haven't worked on this lately. Last thing I tried was running estargz file format to see if it's faster but haven't deployed it onto GHA yet. About the image slimming, I think this problem would require me to understand alot about the dependencies and how they work in OP, and I'm new to OP so I think I would close this for now, and touch on it later once I'm more familiar with OP.

But yeah, like you said, some of the apt packages could be removed right after installing the python deps (curl, etc)

@bongbui321 bongbui321 closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants