Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: set distance lines to max #31728

Merged
merged 12 commits into from
Mar 7, 2024
Merged

Toyota: set distance lines to max #31728

merged 12 commits into from
Mar 7, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 6, 2024

Toyota is rather unique in that the PCM manages the distance lines, so we need to send a button press as if the user is toggling it to get the desired distance.

This makes the lines a consistent far distance like Honda and Hyundai, right now you can toggle it to anything and the 3X flips the relay it's stuck there.

In the future this will come from the saved personality setting and then we will forward the user button press through here.


Looks like you can toggle it pretty fast (me pressing the button), let's stick with 2 frames as a minimum though:

image

@sshane sshane changed the title Toyota: set distance lines to far Toyota: set distance lines Mar 6, 2024
@sshane sshane changed the title Toyota: set distance lines Toyota: support changing distance lines Mar 6, 2024
@github-actions github-actions bot added car vehicle-specific toyota labels Mar 6, 2024
@sshane sshane changed the title Toyota: support changing distance lines Toyota: set distance lines to max Mar 6, 2024
@sshane sshane merged commit cec9f59 into master Mar 7, 2024
27 checks passed
@sshane sshane deleted the toyota-send-distance branch March 7, 2024 11:53
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
* press the button

* 33hz/2

* fix tests

* PCM_CRUISE_SM is a UI message: it goes to 0 when not displayed, and is much lower rate

* only change when enabled so we don't hide the welcome message on cruise main button

* unbump

* then you can get into a weird state

* stuff

* for unplugged DSU we can still read PCM distance, but not buttons

* skip

* skip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant