-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toyota: set distance lines to max #31728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
May 14, 2024
* press the button * 33hz/2 * fix tests * PCM_CRUISE_SM is a UI message: it goes to 0 when not displayed, and is much lower rate * only change when enabled so we don't hide the welcome message on cruise main button * unbump * then you can get into a weird state * stuff * for unplugged DSU we can still read PCM distance, but not buttons * skip * skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toyota is rather unique in that the PCM manages the distance lines, so we need to send a button press as if the user is toggling it to get the desired distance.
This makes the lines a consistent far distance like Honda and Hyundai, right now you can toggle it to anything and the 3X flips the relay it's stuck there.
In the future this will come from the saved personality setting and then we will forward the user button press through here.
Looks like you can toggle it pretty fast (me pressing the button), let's stick with 2 frames as a minimum though: