Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda: Parse distance button from steering wheel #31763

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Mar 7, 2024

Parse the physical distance button from the steering wheel for Honda cars with existing signals defined in the DBCs.

Part of #30850, #31735

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added car vehicle-specific honda labels Mar 7, 2024
@sshane sshane merged commit 32c0bce into commaai:master Mar 12, 2024
31 checks passed
@sunnyhaibin sunnyhaibin deleted the honda-gac branch March 12, 2024 04:49
@MarcoTheDingo
Copy link
Contributor

MarcoTheDingo commented Mar 12, 2024

Found an issue with potentially this PR. Nearby/lead cars on my display no longer show, as well as message "cannot set cruise: speed too low" when the car is/goes under 25mph.

5130484aa8069bad/00000010--c76b9d991a/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants