Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nissan: Parse distance button from steering wheel #31766

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Nissan: Parse distance button from steering wheel #31766

merged 2 commits into from
Mar 12, 2024

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Mar 7, 2024 •
edited
Loading

Parse the physical distance button from the steering wheel for Nissan cars with existing signals defined in the DBCs.

Part of #30850, #31735

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added car vehicle-specific nissan labels Mar 7, 2024
@sunnyhaibin
Merge remote-tracking branch 'commaai/openpilot/master' into nissan-gac
77b9404 
# Conflicts:
#	selfdrive/car/nissan/interface.py
@sshane sshane merged commit 82fa0d7 into commaai:master Mar 12, 2024
26 checks passed
@sunnyhaibin sunnyhaibin deleted the nissan-gac branch March 12, 2024 04:59
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
@sunnyhaibin @cydia2020
Nissan: Parse distance button from steering wheel (commaai#31766)
cc79661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

Assignees
No one assigned
Labels
car vehicle-specific nissan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyhaibin @sshane