Add Fingerprints for all ECUs on 2023 Kia Sportage Hybrid SX Prestige #31993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
date: 2024-03-24T10:14:01 master commit: 82a07af
Adding 2023 Kia Sportage Hybrid SX-Prestige
Added cornerRadar, hvac, and combinationMeter
Added parkingAdas
Removed duplicate combinationMeter
Cleaned up ECU information
|
Looks like #31254 would have fuzzy fingerprinted this |
github-actions
bot
force-pushed
the
master-ci
branch
from
edcb1e1
to
7497ad5
Compare
|
That's okay, that's just a note for myself. You'll want to open your PR against the correct target branch: @jnewb1 can we have the bot check for the correct base branch to avoid these problems? |
Done! Appreciate you guys, cheers mate! |
Hmm, CI does that but there is no CI within the master-ci branch (it's a release branch) |
sshane
added a commit
that referenced
this pull request
Mar 25, 2024
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
May 14, 2024
…#31993 (commaai#32000) * Update fingerprints.py Added missing ECUs and fingerprints for 2023 Kia Sportage Hybrid SX Prestige * remove logging ecus * logging too --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Car
2023 Kia Sportage Hybrid SX-Prestige
Route
d99dc2fc2790c1ab/00000001--0ab81f330c
Notes:
Originally my car was not being recognized, found missing ECUs and fingerprints that needed to be added for it to recognize the vehicle. Tested by installing this branch to my C3X
I added the additional ECUs in the same order they are shown in the logs so future contributors will be able to easily add them.