-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process replay: regen routes #32464
Merged
Merged
process replay: regen routes #32464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf6765f.
…lV2 is not valid, causing radarState to not be valid
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* regen * regen * update * undo * update refs * fix * real fix * test * test2 * test3 * stash * Revert "stash" This reverts commit bf6765f. * rk.lagging can not be trusted. BODY segment has radarFault while modelV2 is not valid, causing radarState to not be valid * order * update refs again * we never logged carOutput! * bump * add back checks old-commit-hash: 220fcc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing routes have invalid liveParameters messages causing controlsd to add
paramsdTemporaryError
events, the newly regen'd routes do not. Since we need to regen the routes for card (#32380) this creates unnecessary diff.