Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move selfdrive/car to opendbc #32630

Merged
merged 10 commits into from
Aug 17, 2024
Merged

move selfdrive/car to opendbc #32630

merged 10 commits into from
Aug 17, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jun 5, 2024 •
edited
Loading

WIP

opendbc PR: commaai/opendbc#1049

Open questions

  • where do torque tuning values go? - openpilot for now
  • some selfdrive tests import from outside selfdrive - stay in openpilot, in future will split on the API boundary
  • panda safety constants require panda submodule - panda is a dep of opendbc
  • test_models should live in openpilot? it compares car state + controls state events against panda
    • A: yes, events will be removed from card
  • come up with struct that holds the car state data. dataclass? capnp?
  • Q: openpilot-specific and car-specific behavior is defined in the car interfaces via events
    • A: use feature flags and openpilot handles the behavior differences. doesn't mention brands. for eg.: enabling on rising edge of resume button or not

@haraschax
Copy link
Contributor

Torque tuning values ideally should go into selfdrive. Does not need to happen from the start.

@github-actions github-actions bot added the car vehicle-specific label Jun 8, 2024
@sshane sshane force-pushed the opendbc-car branch 2 times, most recently from 0051feb to e0b7f12 Compare June 12, 2024 00:39
@sshane sshane mentioned this pull request Jun 12, 2024
Merged
@sshane sshane added this to the 0.9.8 milestone Jul 1, 2024
@deanlee deanlee mentioned this pull request Jul 12, 2024
Closed
@sshane sshane force-pushed the opendbc-car branch 4 times, most recently from e4d8ac3 to e43022d Compare August 16, 2024 22:59
@sshane sshane marked this pull request as ready for review August 17, 2024 06:58
@sshane sshane force-pushed the opendbc-car branch 3 times, most recently from 1e5dca3 to a277862 Compare August 17, 2024 07:37
@sshane sshane merged commit e735a7f into master Aug 17, 2024
18 of 19 checks passed
@sshane sshane deleted the opendbc-car branch August 17, 2024 07:54
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@sshane
move selfdrive/car to opendbc (commaai#32630)
4f019b5 
* move most of /car

* move some car tests

move some car tests

* fix selfdrive/car/tests

* fix selfdrive/controls tests

* fix the rest of the selfdrive tests

* bump opendbc

* fix all tests

* few more non-test references

* remove opcar and move docs to car

fix these debugging scripts

fix docs

* bump opendbc and panda

forgot panda
old-commit-hash: e735a7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car vehicle-specific refactor
Projects
None yet
Milestone
0.9.8
Development

Successfully merging this pull request may close these issues.
3 participants
@sshane @haraschax @adeebshihadeh