Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda: Port 2024 CRV #32806

Closed
wants to merge 34 commits into from
Closed

Conversation

vanillagorillaa
Copy link
Contributor

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 2dc4489d7e1410ca/00000001--32428d7a40
  • route with stock system:
  • car harness used (if comma doesn't sell it, put N/A): Bosch C

Git history is a bit message, broke this off of the Hybrid CRV PR. Non-Hybrid version requires gearbox check, other than that, matches #31527

Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh adeebshihadeh added the car vehicle-specific label Jun 21, 2024
Comment on lines 87 to +91
self.gearbox_msg = "GEARBOX"
if CP.carFingerprint == CAR.HONDA_ACCORD and CP.transmissionType == TransmissionType.cvt:
self.gearbox_msg = "GEARBOX_15T"
elif CP.carFingerprint == CAR.HONDA_CRV_6G:
self.gearbox_msg = "GEARBOX_15T"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just set cvt in interface and use that?

Comment on lines -17 to 18
if CP.carFingerprint in (HONDA_BOSCH - HONDA_BOSCH_RADARLESS):
if CP.carFingerprint in (HONDA_BOSCH - HONDA_BOSCH_RADARLESS - HONDA_CANFD_CAR):
self._pt, self._radar = self.offset + 1, self.offset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we make a new set called HONDA_BOSCH_RADAR or something? also HONDA_BOSCH - (HONDA_BOSCH_RADARLESS | HONDA_CANFD_CAR) might be more clear

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car port car vehicle-specific honda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants