-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honda: Port 2024 CRV #32806
Honda: Port 2024 CRV #32806
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
self.gearbox_msg = "GEARBOX" | ||
if CP.carFingerprint == CAR.HONDA_ACCORD and CP.transmissionType == TransmissionType.cvt: | ||
self.gearbox_msg = "GEARBOX_15T" | ||
elif CP.carFingerprint == CAR.HONDA_CRV_6G: | ||
self.gearbox_msg = "GEARBOX_15T" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just set cvt in interface and use that?
if CP.carFingerprint in (HONDA_BOSCH - HONDA_BOSCH_RADARLESS): | ||
if CP.carFingerprint in (HONDA_BOSCH - HONDA_BOSCH_RADARLESS - HONDA_CANFD_CAR): | ||
self._pt, self._radar = self.offset + 1, self.offset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we make a new set called HONDA_BOSCH_RADAR or something? also HONDA_BOSCH - (HONDA_BOSCH_RADARLESS | HONDA_CANFD_CAR)
might be more clear
We've moved the car interfacing code to our PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you. |
selfdrive/car/docs.py
to generate new docsGit history is a bit message, broke this off of the Hybrid CRV PR. Non-Hybrid version requires gearbox check, other than that, matches #31527