Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix recent test_rotation skip #33167

Merged
merged 1 commit into from
Aug 1, 2024
Merged

CI: fix recent test_rotation skip #33167

merged 1 commit into from
Aug 1, 2024

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Aug 1, 2024 •
edited
Loading

fix from here bfa8e0b

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh adeebshihadeh merged commit 5b4b7a0 into commaai:master Aug 1, 2024
18 checks passed
@bongbui321 bongbui321 deleted the fix_test_rotation_skip branch August 1, 2024 23:45
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@bongbui321
CI: fix recent test_rotation skip (commaai#33167)
cb306fd 
old-commit-hash: 5b4b7a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bongbui321 @adeebshihadeh