Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint.sh: check shebang format for bash + python3 #33286

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

maxime-desroches
Copy link
Contributor

#32761

Enforce #!/usr/bin/env python3 and #!/usr/bin/env bash

@maxime-desroches maxime-desroches merged commit 63a38dc into master Aug 14, 2024
19 checks passed
@maxime-desroches maxime-desroches deleted the lint_shebangs branch August 14, 2024 04:47
@andiradulescu
Copy link
Contributor

andiradulescu commented Aug 14, 2024

Super happy to see the shebang linter!

Should we also check if there is a parameter after #!/usr/bin/env bash? The thing with this shebang is you can’t have parameters (e.g. -e, but set -e). There are two files in this case.

Feel free to reopen and merge #33111

Should we also do it for panda? commaai/panda#1987

Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants