Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back pre-commit hook #33366

Merged
merged 4 commits into from
Aug 23, 2024
Merged

add back pre-commit hook #33366

merged 4 commits into from
Aug 23, 2024

Conversation

maxime-desroches
Copy link
Contributor

@maxime-desroches maxime-desroches commented Aug 23, 2024

Ask if you want to commit anyway if it failed
git lfs already has a post-commit hook, so we put it in the new post-commit.d/ folder to be able to run multiple hooks

@adeebshihadeh
Copy link
Contributor

Instead of asking, I'm thinking we make it a post-commit. It accomplishes the same thing without blocking your next move.

@maxime-desroches maxime-desroches merged commit b87414c into master Aug 23, 2024
21 checks passed
@maxime-desroches maxime-desroches deleted the precommit branch August 23, 2024 22:19
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
* add pre-commit

* space

* post

* e
old-commit-hash: b87414c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants