athenad: fix thread safety issues in upload handing #34084
+27
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses thread safety issues by adding synchronization for shared variables, which previously led to race conditions and data inconsistencies. The updates enhance data integrity and system stability.
cancelled_uploads
. Canceled items are now directly removed fromupload_queue
in thecancelUpload
function, reducing complexity and ensuring consistent synchronization.upload_queue.queue
bypassed the Queue’s synchronization. This update ensures thread-safe access by using themutex
lock provided by the Queue, preventing race conditions.cur_upload_items
.