Preserved selector #34105
Preserved selector #34105
Conversation
|
|
Thank you for the contribution! The code works well, although it feels a bit complex. Additionally, I noticed some UI issues with the route list, such as an odd border on Linux and the route_list_ does not stretch to the full height when the window is resized by dragging(this is an old bug). I can handle fixing these issues and the code cleanup after the merge.
|
|
The old bug one i would rather handle them in a separate issue since they're an old thing. |
|
Yes, you will need to re-parent it after switching tabs. Actually, forget what I said earlier—having two separate route lists works just fine when using tabs. |
|
@deanlee let me know if there are any code tweaks you would like me to do to make this simpler. |
|
Give me a minute so I can experiment with a code change here |
tools/cabana/streams/routes.h
Outdated
| @@ -18,9 +21,14 @@ class RoutesDialog : public QDialog { | |||
| void parseDeviceList(const QString &json, bool success, QNetworkReply::NetworkError err); | |||
| void parseRouteList(const QString &json, bool success, QNetworkReply::NetworkError err); | |||
| void fetchRoutes(); | |||
| bool isPreservedTabSelected(); | |||
|
|
|||
There was a problem hiding this comment.
The blank here is intentional to separate methods from instance variables. But I can remove it if you feel strongly about this
|
lgtm |
Sometimes you use your preserved routes as "favorites". So having a tab in cabana to only show those you're interested in seems like a reasonable feature.