Add port for 2019 Honda CRV Hybrid (China ver) #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iLan/openpilot into devel-2019-honda-crv-hybrid # Conflicts: # selfdrive/car/honda/interface.py
…el-2019-honda-crv-hybrid # Conflicts: # selfdrive/car/honda/carstate.py
eFiniLan
changed the title
|
looks good. @eFiniLan . I wonder if the max steer is really 0x1000. On stock drive I see 0xf00 as max. Not a big deal. Could you please add the newly supported CRV Hybrid 2019 to the list of supported cars in the |
|
@rbiasini cheers! yeah we also noticed that, with LDW the highest is 0xF00 and 0xA00 without. The highest support value is 0x1000 and anything more than that the steer stop turning. I'll get the owner to run a couple more tests on those 3 values and submit another PR later if necessary. README update is done ;) |
rav4kumar
added a commit
to rav4kumar/openpilot
that referenced
this pull request
Apr 1, 2020
rav4 enhancedmeant from @Gernby
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
* 2019 honda crv hybrid port (china version) * adjust mass based on spec * update mass based on spec * add 2019 Honda CRV Hybrid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRV Hybrid doesn't fit into existing CRV or CRV_5G.
Stock Log
OP Log