Add support for Toyota Corolla LE Hybrid 2020 #765
Conversation
Merge OP 0.6
merge upstream changes
merge 0.6.1
|
Looks great. Will review the drive soon. |
README.md
Outdated
| @@ -101,6 +101,7 @@ Supported Cars | |||
| | Toyota | C-HR 2017-19 | All | Yes | Stock | 0mph | 0mph | Toyota | | |||
| | Toyota | Corolla 2017-19 | All | Yes | Yes<sup>2</sup>| 20mph<sup>1</sup>| 0mph | Toyota | | |||
| | Toyota | Corolla 2020 | All | Yes | Yes | 0mph | 0mph | Toyota | | |||
| | Toyota | Corolla Hybrid 2020 | All | Yes | Yes | 0mph | 0mph | Toyota | | |||
There was a problem hiding this comment.
minor: alphabetically, this should go after the Hatchback
| @@ -182,6 +183,9 @@ def check_ecu_msgs(fingerprint, ecu): | |||
| CAR.SIENNA: [{ | |||
| 36: 8, 37: 8, 114: 5, 119: 6, 120: 4, 170: 8, 180: 8, 186: 4, 426: 6, 452: 8, 464: 8, 466: 8, 467: 8, 544: 4, 545: 5, 548: 8, 550: 8, 552: 4, 562: 4, 608: 8, 610: 5, 643: 7, 705: 8, 725: 2, 740: 5, 764: 8, 800: 8, 824: 8, 835: 8, 836: 8, 849: 4, 869: 7, 870: 7, 871: 2, 888: 8, 896: 8, 900: 6, 902: 6, 905: 8, 911: 8, 916: 1, 918: 7, 921: 8, 933: 8, 944: 6, 945: 8, 951: 8, 955: 8, 956: 8, 979: 2, 992: 8, 998: 5, 999: 7, 1000: 8, 1001: 8, 1002: 8, 1008: 2, 1014: 8, 1017: 8, 1041: 8, 1042: 8, 1043: 8, 1056: 8, 1059: 1, 1076: 8, 1077: 8, 1114: 8, 1160: 8, 1161: 8, 1162: 8, 1163: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1176: 8, 1177: 8, 1178: 8, 1179: 8, 1180: 8, 1181: 8, 1182: 8, 1183: 8, 1191: 8, 1192: 8, 1196: 8, 1197: 8, 1198: 8, 1199: 8, 1200: 8, 1201: 8, 1202: 8, 1203: 8, 1212: 8, 1227: 8, 1228: 8, 1235: 8, 1237: 8, 1279: 8, 1552: 8, 1553: 8, 1555: 8, 1556: 8, 1557: 8, 1561: 8, 1562: 8, 1568: 8, 1569: 8, 1570: 8, 1571: 8, 1572: 8, 1584: 8, 1589: 8, 1592: 8, 1593: 8, 1595: 8, 1656: 8, 1664: 8, 1666: 8, 1667: 8, 1728: 8, 1745: 8, 1779: 8, 1904: 8, 1912: 8, 1990: 8, 1998: 8 | |||
| }], | |||
| CAR.COROLLAH_TSS2: [{ | |||
| 36: 8, 37: 8, 166: 8, 170: 8, 180: 8, 295: 8, 296: 8, 401: 8, 426: 6, 452: 8, 466: 8, 467: 8, 550: 8, 552: 4, 560: 7, 562: 6, 581: 5, 608: 8, 610: 8, 643: 7, 713: 8, 728: 8, 740: 5, 742: 8, 743: 8, 761: 8, 764: 8, 765: 8, 800: 8, 810: 2, 812: 8, 824: 8, 829: 2, 830: 7, 835: 8, 836: 8, 865: 8, 869: 7, 870: 7, 871: 2, 877: 8, 881: 8, 896: 8, 898: 8, 900: 6, 902: 6, 905: 8, 921: 8, 933: 8, 934: 8, 935: 8, 944: 8, 945: 8, 950: 8, 951: 8, 953: 8, 955: 8, 956: 8, 971: 7, 975: 5, 993: 8, 998: 5, 999: 7, 1000: 8, 1001: 8, 1002: 8, 1017: 8, 1020: 8, 1041: 8, 1042: 8, 1044: 8, 1056: 8, 1057: 8, 1059: 1, 1071: 8, 1076: 8, 1077: 8, 1084: 8, 1085: 8, 1086: 8, 1114: 8, 1132: 8, 1161: 8, 1162: 8, 1163: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1172: 8, 1235: 8, 1279: 8, 1541: 8, 1552: 8, 1553: 8, 1556: 8, 1557: 8, 1568: 8, 1570: 8, 1571: 8, 1572: 8, 1592: 8, 1595: 8, 1649: 8, 1745: 8, 1775: 8, 1779: 8, 1786: 8, 1787: 8, 1788: 8, 1789: 8, 1904: 8, 1912: 8, 1990: 8, 1998: 8, 2015: 8, 2016: 8, 2024: 8 | |||
There was a problem hiding this comment.
msgs 2014, 2015 and 2024 are related to VIN query. The rest of the fingerprint looks good though.
|
@thesoundofom : could you please let your EON to upload the video files as well for the route you posted? |
|
@rbiasini As far as I can tell everything looks to be uploaded now, I checked both and both the stock and OP routes are visible. Maybe the tail end didn't upload properly but 90% of it is up there... I'm in a very rural area with no internet. Also, I made the change to readme.md as requested. @wocsor thoughts on removing 2015: 8, 2016: 8, 2024: 8 messages? This was the most complete print. |
|
So, bad news: this fingerprint will conflict with the existing fingerprint for the Camry. We really need to move away from CAN based fingerprinting and switch to a VIN based fingerprint. Let's keep this PR open, but unfortunately it cannot be merged as is. |
|
For now, anyone who needs their 2020 Corolla Hybrid LE working on OpenPilot 0.6.6 can switch to this branch on my fork (confirmed working by @Andreybeba today), as seen in Discord... Just SSH into your EON and run... |
|
If this pull request is still relevant, please resubmit it to the master branch. This should allow our development flow to work better, we commit to master, you commit to master, everyone commits to master! Learn more: https://medium.com/@comma_ai/a-2020-theme-externalization-13b33326d8b3 |
|
No worries @geohot. I'm not sure if the Camry fingerprint issue is still current, but I can at least resubmit to master. Thanks |
* First draft doesnt have DP features probably needs to be completely rewritten * minor fixes * opEdit demo * logo * removed comma bull * not needed * topo and add DP * Typo * making Kumar happy * Typos Shouldn't have the user with dyslexia writing your readme but whatever * Fixed APK debate Ready to merge * thanks @Stupefacient for readme Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>
Now working! Big shout out to @wocsor, couldn't have done it without you.
Will provide cabana logs for stock vs op in a few hours.