Honda Bosch with alternate brake message 0x1BE does not validate checksum/counter

[gregjhogan]

The brake pedal press bit used by most honda bosch vehicles was never added to the list of RX messages for checksum/counter validation.

panda/board/safety/safety_honda.h

Lines 27 to 41 in 01bf740

	// Nidec and Bosch giraffe have pt on bus 0
	AddrCheckStruct honda_rx_checks[] = {
	{.msg = {{0x1A6, 0, 8}, {0x296, 0, 4}}, .check_checksum = true, .max_counter = 3U, .expected_timestep = 40000U},
	{.msg = {{0x158, 0, 8}}, .check_checksum = true, .max_counter = 3U, .expected_timestep = 10000U},
	{.msg = {{0x17C, 0, 8}}, .check_checksum = true, .max_counter = 3U, .expected_timestep = 10000U},
	};
	const int HONDA_RX_CHECKS_LEN = sizeof(honda_rx_checks) / sizeof(honda_rx_checks[0]);
	// Bosch harness has pt on bus 1
	AddrCheckStruct honda_bh_rx_checks[] = {
	{.msg = {{0x296, 1, 4}}, .check_checksum = true, .max_counter = 3U, .expected_timestep = 40000U},
	{.msg = {{0x158, 1, 8}}, .check_checksum = true, .max_counter = 3U, .expected_timestep = 10000U},
	{.msg = {{0x17C, 1, 8}}, .check_checksum = true, .max_counter = 3U, .expected_timestep = 10000U},
	};
	const int HONDA_BH_RX_CHECKS_LEN = sizeof(honda_bh_rx_checks) / sizeof(honda_bh_rx_checks[0]);

It can't simply be added as a new, separate message to validate, though, because some honda bosch vehicles (civic hatch) do not have a message broadcast on address 0x1BE.

I believe the following is needed:

• honda bosch vehicles without alt brake message validate 0x17C for gas and brake (no change)
• honda bosch vehicles with alt brake message validate 0x17C for gas and 0x1BE for brake

There is a test ready for this once it is implemented:

panda/tests/safety/test_honda.py

Lines 277 to 285 in 01bf740

	# TODO: add back in once alternative brake checksum/counter validation is added
	# def test_alt_brake_rx_hook(self):
	# self.safety.set_honda_alt_brake_msg(1)
	# self.safety.set_controls_allowed(1)
	# to_push = self._alt_brake_msg(0)
	# self.assertTrue(self._rx(to_push))
	# to_push[0].RDLR = to_push[0].RDLR & 0xFFF0FFFF # invalidate checksum
	# self.assertFalse(self._rx(to_push))
	# self.assertFalse(self.safety.get_controls_allowed())

[adeebshihadeh]

@sshane still an issue?

[sshane]

No, the PR to catch this is not yet in though: #1732