Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rx hooks: check address whitelisted #1732

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

rx hooks: check address whitelisted #1732

wants to merge 6 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 20, 2023

try 2 of #1657, enabled by 3d2f99d.

Now for safety_rx_hook to see msg, it needs to match address, bus, and length of an address in RxCheck struct. Should catch Honda Bosch bug and others like it, where actually-used addresses have their rx checks ignored: #1723

todo:

  • Decide which is cleaner: new hook just to check relay malfunctions, or new struct to specify relay malfunction addresses (for latter, would need multiple structs as addresses, buses are different across safety params)

@sshane sshane changed the title Whitelisted addrs rx hooks: check address whitelisted Nov 20, 2023
@sshane sshane added enhancement car safety vehicle-specific safety code labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant