-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
safety: enforce expected messages in rx hook #1657
Conversation
board/safety/safety_hyundai_canfd.h
Outdated
{.msg = {{0x1a0, 0, 32, .check_checksum = true, .max_counter = 0xffU, .expected_timestep = 20000U}, | ||
{0x1a0, 2, 32, .check_checksum = true, .max_counter = 0xffU, .expected_timestep = 20000U}, { 0 }}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't do this, race condition. need new rx check list, pending a PR like #1655 for CAN FD. ICE cars can be radar ACC or camera ACC
Pre-req for Hyundai cleanups, found bugs there too and want to start with one brand. Also requires a safety param for the interceptor which isn't in the address checks, but dynamically detected. |
not sure how to handle the interceptor param yet, don't want to double the addr checks (?) |
Valid should be false if message is not in address checks. Catches a lot of missing checks/bugs in test_models
There are some impacts to think about with the interceptor safety param:
Meanwhile:
So the interceptor param addition should strictly be safe.