IsoTpMessage: return if consecutive frame last received #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlocoteta
pushed a commit
to mlocoteta/panda
that referenced
this pull request
Apr 29, 2023
* what about * actually this is what we want * more explicit about this condition * frame type * add enum * use in func
budney
added a commit
to budney/panda
that referenced
this pull request
May 5, 2023
commit f225c1122743b1bdb0a17e48d05b2bd99676b462
Author: ClockeNessMnstr <locke.dftc@gmail.com>
Date: Wed Feb 9 21:56:36 2022 -0500
3071 panda
commit cedb5fd1a6c0823703280b1941edfed9602a287d
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu May 4 06:08:10 2023 +0000
Ford: remove safety mode from debug flag (#1400)
remove from debug
commit 94cd9a0788070e4e802e8a6a1c1cc7dae95e8f70
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu May 4 04:59:35 2023 +0000
Ford: curvature rate limits (#1258)
* ford curvature rate limits draft
* make common angle tests work with curvature
* comment
* no need for this
* extra line
* fix test
* generic curvature test class
* more reasonable limits
* adjust limits
* draft
* works
* works
* clean up
* add vehicle speed
* works
* clean up
* clean up
* more clean up
* more clean up
* lower
* double
* add updated bp
* remove
* can clean that up
* draft
* this works!
* think that's the correct placement
* try this
* closer
* use min
* add/sub one to not falsely trip
* remove old angle error safety
* i'm not sure if clamp is more readable
* fix that
* fix
* stash
* fix these tests
* ternary
* floats are a pain
* draft, works kinda
* even better
* round that
* need tolerance
* this should work (adding tol=1 wouldn't let us have multiple rate limits)
* test works
* clamp breaks if low is higher than high :(((
down from 150 blocked msgs to 7!
* no blocked msgs!!!
* test a whole bunch
* stash
* stash
* clean up test
* clean up test to be more like torque (+ speeds)
* clean up
* cmt
* test up
* up and down are good
* rename and remove
* this is tested
* uncomment
* this is tested by ensuring we move towards error at a minimum rate
* not used any more
* revert common
* clean up test_ford a bit more
* some clean up (combine variables where it makes sense)
* yeah can't use clamp since min isn't always < max, min(max(.. handles this
* clean up
* revert that
* comments
* cmt
* another
* that's old
* misra!
* Update board/safety/safety_ford.h
* Update board/safety/safety_ford.h
* add todo, fix test case
* more clear, matches panda
* add comment
* Update tests/safety/test_ford.py
* more fine speed increments
* rm comment
* better names
* this is expected behavior (tested by common checks)
* CURVATURE_ERROR_LIMIT_SPEED
* better name?
* pretty clean!
* same for up
* only used in one place now
* these are now clear
* common term
* make vehicle_speed a sample_t
* need to use values[0]
* speed is a float
* Revert "speed is a float"
This reverts commit 01af02f1d35026d983cc2ba6d9ba364c87c800ee.
* Revert "need to use values[0]"
This reverts commit 8f6d68345a92f7285d07ca071285e903ed7871bb.
* Revert "make vehicle_speed a sample_t"
This reverts commit ecd8dc86b6b97cc8bff7da697353a8d90c358b12.
* safety fixes for new speed sample
* test fixes for new speed sample
* fix misra and make intermediate variable
* this isn't needed
commit b44df8151a15fa3afe8a8943e332eb63605a2245
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu May 4 04:09:09 2023 +0000
safety tests: use rx/tx helpers (#1399)
use rx/tx helpers
commit 3a64b6ccb51301a9f1c7e8f9fd121940d50d01d8
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu May 4 03:37:56 2023 +0000
safety: make vehicle_speed a sample (#1391)
* convert vehicle_speed into sample_t, change no behavior
* draft
* round
* test
* clean up
* round
* round all
* use min
* remove round macro from this PR
* reset speed measurement
* debug
* bbd
* rm
* revert
* test above and below
* need this now
* misra pt 1
* misra pt 2
* misra pt 3
* i don't understand this one, not different from other cases
* fix test
* test
* revert that
* draft
* test the sample_t works properly for safety modes that use it (angle only)
* can combine these tests
* test decimals
* global
* misra
comment
* suggestions
* fix
* use new helper
commit 5a9603600ec247ac01ffe818efd7cc363af8ec9b
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu May 4 02:51:08 2023 +0000
safety tests: reset safety helper (#1398)
* reset safety
* use it
* clean it up
* two lines
* fix python linting
commit 776bb69945e2ab5bf4cfb993b18fcc3f543e95b4
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 21:37:04 2023 +0000
Ford: test angle measurement (#1396)
* test angle meas readback (ensures speed and yaw rate are used properly)
* revert
* rm
* tuple
* temp
* clean up
* stash
* Revert "stash"
This reverts commit cab96b3e2b46d7b43ef539b96e0f6d3918d21e55.
* use global
* test negative
* name
commit 4b0427551412fd1ac4ca31d8aa376b090afb0435
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 21:19:52 2023 +0000
Ford: test angle error speed in steering signal test (#1395)
* test above and below limit speed
* need this now
commit ba5c2948e4ed23a1ec61e96d2197571fb599d8e4
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed May 3 14:15:34 2023 -0700
python: default to 60s timeout for recover() (#1394)
commit 810df6b5c18619a048aaf296f332a627fa8f517d
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 05:01:44 2023 +0000
safety replay: safety tick (#1364)
* make explicit, there was no bug only because the if statement is identical to above
* debug
* Revert "debug"
This reverts commit 2ec83677c3749f805681c4874b746696767f7634.
* Revert "make explicit, there was no bug only because the if statement is identical to above"
This reverts commit fcb2a106b9694727ca4b5a9acf4eda3312fc4271.
* fixes
* remove
* allow 1 second
* remove
* clean up
* call every can msg
* safety_tick_rx_invalid like test_models
* order
* skip end
* try that
commit 3a3e117d01cf8c02a3bb84ba7b3b6e4034c72302
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 04:35:00 2023 +0000
Ford: remove unused function (#1393)
we can just round this now
commit aa30b15de5a128faafd8a1c4809d502c2a894609
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 03:45:33 2023 +0000
Ford safety: more clear variable names (#1392)
* that's a better name
* that too
commit 22b245372852c002c06bd272fdcfe5d5e4db828b
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 00:34:24 2023 +0000
angle safety: consistent rate limit variable names (#1390)
consistent names
commit 69ad3dd8e885b61931ad65aa0cd014d694a2efe5
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed May 3 00:07:23 2023 +0000
angle safety: add comment about rate limits at 0 (#1389)
* up when 0
* Revert "up when 0"
This reverts commit fc9b459651826e5ca8d597920d4fea49eedb15d5.
* add comment
* whoops
commit 14cfb78ab2d6d8a11d30bbcd504b8b6391311d31
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue May 2 13:45:21 2023 -0700
Subaru: add gen 2 Outback route (#1386)
gen2 outback route
commit 1d1284e863e32bdbe6b6f9db5a011cdcbdeeb4c5
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue May 2 13:18:26 2023 -0700
Revert "Subaru: add gen 2 Outback route (#1385)"
This reverts commit c43f33191cd205966a275cec2b2afda6c9a6c7b6.
commit c43f33191cd205966a275cec2b2afda6c9a6c7b6
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue May 2 13:07:50 2023 -0700
Subaru: add gen 2 Outback route (#1385)
gen2 outback route
commit 2fb25c4a0bfe7d2294522cf13d1f1def5080e2e2
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue May 2 01:21:33 2023 -0700
Subaru: fix Impreza replay route (#1384)
* fix
* impreza route
commit 641d9c4f3a47f2a95dfca643082f83b10b2b102f
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Tue May 2 09:55:00 2023 +0200
Tesla: DAS_control is on bus 2 (#1374)
these are on bus 2
commit 8e1ca608b0fc3de389d637a1bfb930369220ac96
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon May 1 20:18:23 2023 -0700
H7: remove busy wait on TXC (#1381)
* works
* cleanup
* less irq
* less diff
---------
Co-authored-by: Comma Device <device@comma.ai>
commit f9485c8d5d716d3429a0a24288fb83256d6a9d9e
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon May 1 20:01:03 2023 -0700
Ford: more clear steering safety check (#1383)
one line
commit a5718ce5dd9d3ca568a6b023b2aec5b2bfda5b2d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon May 1 19:31:13 2023 -0700
spi: different ack dummy bytes for debugging (#1382)
different ack vals
Co-authored-by: Comma Device <device@comma.ai>
commit dbe941004a03ebfcf82bac61b0b94999a7e12abe
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 28 17:45:02 2023 -0700
safety: reset torque_meas on init properly (#1250)
* reset min torque meas too
* add test that fails
* cmt
* cmt
* clean up test
* don't be random
* above test tests this pretty much
* test angle too
* fix
* also test driver torque
* whoops
* whoops
commit 63db708491aef4fc8d278368d99c0e4fdf86f1dd
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 28 17:36:35 2023 -0700
driver torque limit: make driver torque message abstract (#1377)
* abs
* uncomment
* fixy
commit 99809f7071c783cd16547771e2dea3c34d669aa4
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 28 15:02:57 2023 -0700
angle safety tests: more clear helper function name
here too
commit 001f9917ef50660a03f01feeabc73b42babc2e24
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 28 14:25:35 2023 -0700
ford: disable counter check for second speed (#1375)
add comment and disable counter for second speed
commit 4160d8d71cbb5cd40107834ad4756c4dbffc63b0
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Apr 27 23:33:54 2023 -0700
safety: common angle safety function (#1369)
* draft clean up
* always check
* add angle to name
* ford sends curvature when not steering and bit is 0.
it's not torque, curvature of 0 will still apply torque
* need this to be generic
* formatting
* rm
* test that we can send curvature=0 if enabled=False while control_allowed=True (let's say EPS faults, OP doesn't want to actuate)
* revert ford tests to master
* this <i>should</i> preserve behavior
* this is fine to remove
* and this should also be covered
* yeet
* change opt name, combine checks, much better!
* one more
* modes
* Add comment
* misra has a bug :(
* ugh
* make this clear
* ?
* order
* fix
* comments
commit 69a0b6ed34118ca5a92c2e70e2d231dbb98e19d5
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Apr 27 23:19:26 2023 -0700
safety: use max_limit_check helper in angle safety (#1373)
* better
* ?
* ?
* Revert "?"
This reverts commit ae70c7ff3b41e49ccc149b7b202fdcde0a120e8d.
* Revert "?"
This reverts commit db7fd644a9cedfc46583651fe7581e4862b0f77e.
commit aac46a2ef29edadd8798eb8997a931bf165fa0ae
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Apr 27 21:41:38 2023 -0700
angle safety: enforce disabled angle when not steering (#1372)
* enforce disabled angle when bit not set, below we enforce bit to be 0 when not controls allowed
* test
* other test
* combine tests
* comment
commit 240370cdd1df17ae13a9f24b8ebf72c3a45c551b
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Apr 27 17:44:32 2023 -0700
ford: allow 0 curvature when controls are allowed if not steering (#1370)
* test that we can send curvature=0 if enabled=False while control_allowed=True (let's say EPS faults, OP doesn't want to actuate)
* draft
* only check error if apply bit is 1
* subtest
* no subtest
* fix safety and tests
* tests say this works
* clean up
* subtests are sloww
* Revert "subtests are sloww"
This reverts commit 560c6745c8dddfcce87113e36e3661274fbb239b.
* fix test from merge
* add comment
* add comment
* add another comment
* spacing
commit 07680692d99c2856e5fff6e01f5bf0d3d49c88f6
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Apr 27 17:27:18 2023 -0700
Ford: add subtests (#1371)
* subtest here
* and here
* bit faster
commit c9c3cb38f6102ed3f72cee9720293be6c581e7ee
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Apr 27 00:40:29 2023 -0700
Ford safety: curvature error limit (#1353)
* set ford vehicle speed
* parse yaw rate signals
* misra
* misra
* misra
* misra
* draft
* update module
* already checked
* and set it properly
* some stuff
* draft
* clean up (will fail tests because we don't send yaw rate yet)
* could do something like this
* this is better and less prone to bugs
* match simple op limiting, debugging
* set checksum for messages in tests
* clean up
* fix that
* one m/s fudge
* fix sign of yaw rate
* interpolate detects size
* forgot OP flips the curvature sign. it matches yaw on can
* all my debugging crap
* make replay work for ford
* fix panda blocking messages (array is fixed size so size-1 is 0 rate at high speed)
* uncomment safety test limits
* revert
* round for zero blocked msgs
* fix limits
* meas safety checks that down rate is >=, not <
* test pass
* lots of comments and draft what one meas torque check would look like
* fix that
* add curvature meas
* add debugging stuff
* Revert "add debugging stuff"
This reverts commit 449783fc625954868a1cfca48a655cac7b074cc1.
* messy but at least one test passes now
* draft
* add max_steer
* some safety clean up
* and that
* start with a test that works
* another test that works (sort of, we need more strict panda safety without false positives)
* no max curvature check (not safety related), allow any rate limits
* add new function
* also need to consider max val here, since OP will send up to that
* and now use the function
* lower to 10
* compilation fixes
* clean up (no rate limiting)
* remove that too
* curvature diff test
* more clean up
* debug
* ?
* better names
* more official
* use _curvature_meas_msg_array here
* bit faster
* no i don't
* revert that
* why not just use angle_meas?
* bb ll
* bb deb
* clean up debug vals
* more
* revert replay drive debugging changes
* Update board/safety.h
* rm line
* only need to round the final thing
* not needed, under 10 ms
* make a class variable
* fix a misra?
* another misra?
better
* ?
* 12.1
* need to explicitly convert
* add one to not false trigger the violation (float rounding)
* not really needed
* rm line
* cmt
* use clamp
* rename
* in struct
* comment
* use max_limit_check
* draft clean up
* Revert "draft clean up"
This reverts commit d1a0e8acd1d0eb2bd7b75618c7df14e15c16e134.
* make a global
make a global
* this is fine
commit 4269b74a8488bc88c5e3e9c355b623751bd2656b
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Apr 26 23:55:04 2023 -0700
safety: use max_limit_check (#1368)
use max_limit_check
commit 1e8c5d59c7aed45aaca580c99197a1248abd0209
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Apr 26 23:15:28 2023 -0700
CI: run tests with UBSan (#1363)
* CI: run tests with UBSan
* try this
commit 7aef934d4cd740dc5f25a64cf2675b2ecf7f7525
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Apr 26 22:59:58 2023 -0700
Fix undefined behavior in GET_BYTES macro (#1367)
commit f444f1554f7c076244aa00ec30531716522eb017
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Apr 26 22:37:36 2023 -0700
Ford: check second speed for mismatches (#1358)
* Add second speed
* 2.5 m/s is 9 kph, 4 kph is the max in the field
* add quality signal
* qf signal name
* comment
* checksum matches except it goes to zero when turning the car off despite counter still active
* update comments
* now test it
* spacing
* Update board/safety/safety_ford.h
* zzzz
* not needed
* whoops
* test vehicle state mismatch
* add to safety_helpers
* probably misra
* we might want to check it in both speed signals in case one doesn't exist on a car
* Revert "we might want to check it in both speed signals in case one doesn't exist on a car"
This reverts commit 3338931409327f9c0eaa6fbd0daa9a57ef229b46.
* fix formatting
* 2 m/s (7 kph)
* set controls_allowed directly like other safety models
remove vehicle_state_mismatch
* obv
commit 5c21b140495ef72f36f90d26a6c740c101012752
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Apr 26 21:49:39 2023 -0700
Ford: check 2nd speed message (#1365)
* Add second speed
* 2.5 m/s is 9 kph, 4 kph is the max in the field
* add quality signal
* qf signal name
* comment
* checksum matches except it goes to zero when turning the car off despite counter still active
* update comments
* now test it
* spacing
* Update board/safety/safety_ford.h
* zzzz
* not needed
* whoops
* test vehicle state mismatch
* add to safety_helpers
* probably misra
* we might want to check it in both speed signals in case one doesn't exist on a car
* Revert "we might want to check it in both speed signals in case one doesn't exist on a car"
This reverts commit 3338931409327f9c0eaa6fbd0daa9a57ef229b46.
* fix formatting
* 2 m/s (7 kph)
* revert mismatch stuff
commit 048ddeea4a87b8f20f7cef69ee75de7df5b71f40
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Apr 26 21:15:55 2023 -0700
safety: make addr index getter more explicit (#1361)
make this explicit
commit f3d6d613c0b1015fb90e51023cf67abe9ae4726f
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Apr 26 19:43:30 2023 -0700
safety: don't check out of bounds array item (#1360)
* safety: don't check out of bounds array item
* better name
* cleanup
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit 23b5130de9d95fa049712da9230f3ce5e076593a
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Apr 26 17:45:04 2023 -0700
replay drive: fixes (#1362)
* make explicit, there was no bug only because the if statement is identical to above
* debug
* Revert "debug"
This reverts commit 2ec83677c3749f805681c4874b746696767f7634.
* Revert "make explicit, there was no bug only because the if statement is identical to above"
This reverts commit fcb2a106b9694727ca4b5a9acf4eda3312fc4271.
* fixes
* clean that up
* and this
commit b342c2d724125b3d12b88a53c2f87ba01c8043d0
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Fri Apr 21 15:41:26 2023 -0700
fan: add stall threshold backoff (#1357)
* fan: add stall threshold backoff
* Update board/config.h
* cleanup
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 08ed853bf9d3dccc0263f7bb0d0d6d3f7872f015
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Fri Apr 21 13:47:13 2023 -0700
log total stall count in fan tuning script
commit 272b81e97b89dd10d8e9e3b01d1854fb1b742feb
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Apr 20 15:44:12 2023 -0700
fan: fix stall detection (#1351)
* cleanup and fix
* dos must stall
* clean those up
* fix misra
* more test
* fix import
* cleanup
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 6093301bc9ad150e50a5d5391a3ec100d86602c2
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Apr 20 14:34:11 2023 -0700
add CLAMP macro (#1356)
* add CLAMP macro
* fix
commit 3c75a8bc00f503f59a32fead3098afa88139ba07
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Apr 20 13:30:56 2023 -0700
add fan stall count to health (#1355)
* add fan stall count to health
* fix misra
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 0e2eb9c0f5b33a6650ec6e5638af6f33bb5b1d63
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Apr 20 13:00:40 2023 -0700
fan debugging script (#1354)
* fan debugging script
* merge those
* disable
* better print
---------
Co-authored-by: Comma Device <device@comma.ai>
commit e6cad019554a7bd87d5a30ef648bd20fa91af510
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Apr 19 17:34:31 2023 -0700
H7: fix CAN FD IRQ rate (#1332)
commit cf307348af6eb5d7bf4dc3f5a11e2d1f3feadfad
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Apr 18 22:17:11 2023 -0700
CI: run HITL tests on tres (#1326)
* run on tres
* disable those for now
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 0b03ef5468aa737247965c3717ccc248465cdc4f
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Apr 18 16:15:27 2023 -0700
HITL tests: skip internal tests on uno (#1350)
Co-authored-by: Bruce Wayne <batman@comma.ai>
commit d3904a9f751248cd2e887e89d0db2f6b6239f4b6
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Tue Apr 18 14:47:22 2023 -0700
HITL fan test (#1330)
* hitl fan test
* enable cooldown on dos as well
* small cleanup
* get expected RPM from panda class
* fix
* overshoot test
* fix max RPM getting
* fix percentage
* revert cooldown fix
---------
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit 237ffedcb31f8eb786aceac9b22e5224aed89b61
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Tue Apr 18 14:15:06 2023 -0700
Dos fan fix (#1335)
* hitl fan test
* enable cooldown on dos as well
* small cleanup
* get expected RPM from panda class
* fix
* overshoot test
* fix max RPM getting
* fix percentage
* revert cooldown fix
* add cooldown for dos fan as well
* remove feedforward from the fan controller to eliminate overshoot
* update clip
* cleanup
* add that back
---------
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit 1f8b03666d8f8ed377e9af89cffc5b1bdd70e922
Author: Justin Newberry <jnewberry0502@gmail.com>
Date: Mon Apr 17 21:47:51 2023 -0400
Subaru: add ability to send infotainment status message (#1333)
* added infotainment status to panda
* dont fwd infotainment status
* revert placeholder and add test case
* Fix test case
* gen2 only
* fix test case
* Revert "fix test case"
This reverts commit 8cc7579620100edec7ed89bf3277667a2124cd0a.
* Revert "gen2 only"
This reverts commit 6a511a997660010ea01658cfdb8e852b4f131855.
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
commit 2f7962189329ce5da5d68cb3261982aaa84b0deb
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Apr 16 15:08:46 2023 -0700
improve flash and recover scripts (#1349)
* improve flash and recover scripts
* update references
* cleanup
* less spaces
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 9cd01ac26371571432c42b901fe1ac54f393ee17
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Apr 16 14:43:58 2023 -0700
PandaDFU: retry SPI comms (#1348)
* retry
* set exc
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 862b03b5c53b33a6143608bedbf53eb4a6b8c6eb
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Apr 15 17:56:25 2023 -0700
CI: add job to update pre-commit hooks (#1346)
* CI: add job to update pre-commit hooks
* rm push trigger
commit 6ec078db5a1bc5e34caf0e28df202a3f76617d40
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date: Sat Apr 15 14:34:42 2023 -0400
VW MQB: Cleanup HCA control message (#1310)
* VW MQB: Cleanup HCA control message
* update opendbc ref
* revert this before merging
* MISRA
* revert Dockerfile to comma master
* reverted a little too much
commit ada8b49cb5940d306c529156622022be2d7fdaa2
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Apr 14 01:51:19 2023 -0700
Honda Bosch Radarless: allow alt brake (#1341)
* radarless can use this
* fix addr check
* update opendbc ref
commit 0117ff9d131eb22c0737e0758ab9178acec19744
Author: Igor Biletskyy <briskspirit@users.noreply.github.com>
Date: Thu Apr 13 17:37:48 2023 -0700
H7: Rx FIFO lost counter (#1345)
* fifo rx lost counter
* add comment
commit fddca54fd6f9830ebbfb8efa287f902331b35f88
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date: Thu Apr 13 20:28:33 2023 -0400
VW: Allow inactive accel values at all times (#1247)
* allow inactive accel values at all times
* cleaner
* unnecessary, done by default
* better comments
* move test to common class
* fix
* flip
* comment
* append 0 and INACTIVE_ACCEL to test accels + check acc_07 sends if inactive only
* cleanup
* fix that
* copy testing convention of VW and Honda
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
commit 22b8e5df7f6a5241c417775e9fec545d94889dfd
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Apr 12 16:28:45 2023 -0700
add extra fault assert in HITL tests for context
commit 9e03d10857e456a4f0119f09de5a2bb76c9504f6
Author: royjr <royjr96@gmail.com>
Date: Wed Apr 12 19:22:19 2023 -0400
README: better setup order (#1337)
commit 0832d65347619439137900599d92cdd2b8d8d194
Author: Igor Biletskyy <briskspirit@users.noreply.github.com>
Date: Wed Apr 12 11:07:58 2023 -0700
Fix CAN message corruption on H7 under high load (#1342)
* fix RX FIFO corruption
* Add checksum to CANFD test data
* cleaner and MISRA
* nah
* oops
* fix test
commit 6d86f546c0214448d4d339f9f85625cf08c494e9
Author: royjr <royjr96@gmail.com>
Date: Tue Apr 11 22:38:02 2023 -0400
README: fix git error while trying to build (#1344)
Update README.md
commit 85cc70d4aa3797d0b30e22064b755b7dd472767f
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Apr 8 16:45:59 2023 -0700
safety: only pass addr to fwd hook (#1339)
commit 2a567674dc2a8925ab270b6de720f2ae0e16241a
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Apr 8 16:20:38 2023 -0700
Tesla: move reading AEB state to RX hook (#1340)
commit a1390647fc650d7a52347579d15e9cf44c54bf67
Author: royjr <royjr96@gmail.com>
Date: Fri Apr 7 21:05:00 2023 -0400
README: fix error while installing requirements (#1336)
fixes error while installing requirements
commit 878e0077ac077c5325b37710b8df856468d85674
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Apr 6 20:52:09 2023 -0700
add tres to internal devices
commit 6f852b44a9ef1ee119fabf6aa2a9c477ed594a46
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Apr 5 22:05:14 2023 -0700
SPI: log checksum errors in health (#1334)
* SPI: log checksum errors in health
* actually send it
* check in hitl teardown
* check that
* fix misra
commit 2e8f27486f1522db6d442fb9e9c261a0a2eee1d2
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Apr 5 09:15:31 2023 -0700
spi: bump up to 50MHz
commit e516a5752b56d9b95229042c5cca8c74b6a9feb0
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Apr 4 18:51:35 2023 -0700
watchdog to log fault on heartbeat loop (#1328)
Co-authored-by: Comma Device <device@comma.ai>
commit 0400ac28af22e63721c940e160c622b97d0c8b6b
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Apr 3 20:48:26 2023 -0700
fake siren: fix false positive fault (#1327)
commit eef3d026e37e64a1ba42f70b6a9e83b2f58dad55
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Apr 3 20:21:10 2023 -0700
CI: run HITL tests on dos (#1304)
* run on dos
* skip voltage on dos
* run these
* revert that
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 79708f912dc1681c99569b59624de74fa9341a31
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Mon Apr 3 17:13:02 2023 +0200
USB enumeration based on frame numbers (#1324)
* use frame numbers to detect host connection
* fix weird formatting
---------
Co-authored-by: Comma Device <device@comma.ai>
commit b6c378ad02cd7902ba8a13572b08e9c9d4ed3070
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Apr 2 09:33:35 2023 -0700
CI: set PYTHONWARNINGS=error (#1323)
* CI: set PYTHONWARNINGS=error
* update resetter
* fix build warnings
* bump jungle
* fix one more
* fix linter
---------
Co-authored-by: Bruce Wayne <batman@comma.ai>
commit 3e89b7127ad6162ccbed29ad4af10a54528ed058
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Apr 1 23:09:12 2023 -0700
python: fix libusb deprecation warning (#1302)
* update list
* this one too
* update dfu
commit 416981d1f73aee8ffc4e936ecd79f47b35294a7b
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Apr 1 19:28:54 2023 -0700
CI: setup tres (#1322)
commit 6a8ed7f1477057144f6a9cd6e1003e76afcf2b9f
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Apr 1 18:52:32 2023 -0700
CI: setup dos (#1321)
* CI: setup dos
* just build and flash for now
* fix new device setup
commit 8efbcf041c1b6da1764bb56f822609fd4bb0758f
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 31 20:11:53 2023 -0700
IsoTpMessage: return if consecutive frame last received (#1314)
* what about
* actually this is what we want
* more explicit about this condition
* frame type
* add enum
* use in func
commit a12c0a795678373d946b644b43d9402b72e502a9
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 31 19:44:46 2023 -0700
IsoTpMessage: don't skip a byte when sending consecutive frames to subaddress (#1320)
handle
commit 189f0436ba3625b938015fc59e68a53a5bdba143
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 31 19:22:16 2023 -0700
IsoTpMessage: check CAN frame length (#1315)
* Revert "Revert "IsoTpMessage: check CAN frame length (#1312)""
This reverts commit 09fee3e7ead96a6a9613430c81bb2d3e095aa0fe.
* need to pad for the check to work
* pass rx_offset up from can client
* detect from internal can_client and just use it for the checks
* move
* revert this for another PR
* fix
commit c92f8ecfde847edea7778f75c25f05047b770c77
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 31 19:17:16 2023 -0700
IsoTpMessage: fix rx_len sanity checks (#1319)
fix a bug
commit cb3530916064b147cb7b8539035c7c0689d6ee47
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Fri Mar 31 14:39:30 2023 -0700
spi tx timeout print
commit 02eb84936b62cc37d7e3f1753cb501ebe547bf27
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 31 13:59:02 2023 -0700
UdsClient: support sub addresses (#1317)
* UdsClient: support sub addresses
* Update python/uds.py
* Update python/uds.py
commit 09fee3e7ead96a6a9613430c81bb2d3e095aa0fe
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 31 12:11:13 2023 -0700
Revert "IsoTpMessage: check CAN frame length (#1312)"
This reverts commit 9349337ebb7cad601ef881265af1d27a2115d1b9.
commit 7933635b54b68eda3f8a906d5e2c3ca30dbed279
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 30 23:23:42 2023 -0700
IsoTpMessage: rx_len sanity checks (#1311)
* add some more sanity checks for _isotp_rx_next
* another PR
* Update python/uds.py
* cannot be bigger than 0xfff
commit 23563cec7c03a5a3718b29ec206fed1c8cee8edd
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 30 22:35:02 2023 -0700
IsoTpMessage: check not reserved frame (#1313)
* add some more sanity checks for _isotp_rx_next
* another PR
* rever
* can remove return
* add back the space here tho :(
* raise
commit 9349337ebb7cad601ef881265af1d27a2115d1b9
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 30 22:14:35 2023 -0700
IsoTpMessage: check CAN frame length (#1312)
* add some more sanity checks for _isotp_rx_next
* another PR
* revert
commit 12b9b65985edf7207a1dfd48de0b714192e6e55d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Mar 29 15:07:12 2023 -0700
fake_siren: add fault on codec enable failure (#1308)
* fake_siren: add fault on codec enable failure
* little shorter
---------
Co-authored-by: Comma Device <device@comma.ai>
commit a1e1451d1c2f23b953d82eea7691a657c9a8a75a
Author: Vivek Aithal <vivekaithal44@gmail.com>
Date: Wed Mar 29 10:39:25 2023 -0700
GM: Reduce steer down limit and increase driver allowance (#1281)
reduce steer down limit and increase driver allowance
commit 7392f24868ec018fb83b27cf7953761b0904d2bf
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 28 00:05:35 2023 -0700
Honda tests: check endswith Base to skip test (#1305)
check endswith base
commit db6c50cd09f773c231f962fc0e31b4612c572b08
Author: royjr <royjr96@gmail.com>
Date: Tue Mar 28 02:10:25 2023 -0400
Honda Bosch Radarless longitudinal safety (#1008)
* civic22_long
use long flag
* maybe?
* Update safety_honda.h
* revert the 0x1c8 addition
* init radarless safety check
* correct accel parsing
* add test class (WIP)
* remove current_controls_allowed
* Fix ACC_HUD
* patch
* Add missing safety to test name
* Pass irrelevant test
* move comment
* remove unused comments
* add comment to TestHondaBoschRadarlessSafety
* Fix message overlap
The "exceptions for common msgs across different hondas" fix does not seem to be working. Created another exception for TestHondaBoschRadarless based on the HondaNidec exception above
* Fix base
* remove comment
* remove buttons from LONG TX
* make a base Radarless test class
* can't remove them, since safety doesn't check bosch
* test accel limits
* test accel limits
* we can do the clean up in another pr
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: sshane <shane@smiskol.com>
commit 01ea26e342a2b84059ee6361ee0124d7e39b036b
Author: Igor Biletksyy <bs@privacy.im>
Date: Mon Mar 27 10:38:04 2023 -0700
prevent host from setting wrong returned flag
commit 6cb3561f1687efdc4bb04d812ab15e269b7626e8
Author: AlexandreSato <66435071+AlexandreSato@users.noreply.github.com>
Date: Sat Mar 25 23:02:34 2023 -0300
safety replay: update Honda steer value getter (#1292)
* safety replay: update Honda steer value getter
I think now it´s right!
```
BO_ 228 STEERING_CONTROL: 5 EON
SG_ STEER_TORQUE : 7|16@0- (1,0) [-4096|4096] "" EPS
```
* ops
commit f29125f6ade6f0f5a5ecb5b23c1f3169fe1d80a0
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 22 21:57:18 2023 -0700
DriverTorqueSteeringSafetyTest: remove useless function (#1275)
Update common.py
commit 7aaca348c22089abcbd695afc0430da7f28a609c
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Mar 22 21:38:37 2023 -0700
HITL tests: nose -> pytest (#1301)
* HITL tests: nose -> pytest
* run all
* add back partial tests
* big speed up
* fix skipping
* enable all
* that's expected
* clean up after ourselves
* jungle is fixture
* fix
---------
Co-authored-by: Bruce Wayne <batman@comma.ai>
commit c5cd0a0232039807ab95b68babb91c91f3a5319d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 21 18:49:58 2023 -0700
Enable siren for multi-panda setups (#1300)
commit ba7d21805a0a0d6770a522ef6c39bca537361e61
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 21 18:49:47 2023 -0700
ci: lower safety test timeout
commit ba50c2ffee990ca3cbfdcebd1cf750c9046a11a7
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 21 12:42:02 2023 -0700
safety tests: fix for common longitudinal accel class (#1299)
* fix
* fix
* something that would catch this
commit 2136e2e45bf083d36b6cfc451fce6bff40dc48da
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Mar 21 12:24:33 2023 -0700
safety tests: add common longitudinal accel class (#1298)
* add longitudinal safety test class
* rename to accel_cmd_msg
* line
* do hyundai
* set default min and max accel
* revert
* thanks pylint
commit d70fa4e1200ad47c66587c78fd90030a3be1cc43
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 21 11:19:12 2023 -0700
tres: fix fan spin on startup (#1297)
* tres: fix fan spin on startup
* new init
commit f658ecdd75649441179928eafcaff64001f147c0
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Mar 18 20:35:55 2023 -0700
ci: speedup safety tests
commit e4cc97d8826dc95a7833b859c36948302445a499
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 16 22:56:25 2023 -0700
Toyota: check SETME_X64 signal for LTA (#1296)
* check SETME_X64
* use itertools.product for better coverage
* fine
commit c83d6894ef273424cb1b388dac9bc037f862692d
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 16 22:32:56 2023 -0700
Toyota: base LTA safety (#1295)
* part 1 of clean up
* make it work and pass
* remove lta stuff
* remove commented lta tests
* more
* move test back to where it was
* rm line
* rename that
* fix that
* start to add LTA
* angle test
* fix tests and add base stock longitudinal class
* formatting
* clean that up
* convention
* add ALLOW_DEBUG
commit 7fdc66b95778feda476a81ec14e57b98e5dda508
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 16 21:58:38 2023 -0700
Toyota: more modular safety tests (#1294)
* part 1 of clean up
* make it work and pass
* remove lta stuff
* remove commented lta tests
* more
* move test back to where it was
* rm line
* rename that
* fix that
* we always want to enforce LTA disallowed actually
* not sure if these are helpful
* endswith("Base")
commit c0aea3273a82a91f10554b1b3317727da99f4564
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Thu Mar 16 14:15:43 2023 +0100
Tres: fan cooldown + no stall recovery (#1287)
* add fan cooldown
* refactor to be inside the fan driver
* fix rebase
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 56fae8a2833d251c9180365ca1323a2dc11824c9
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Thu Mar 16 11:24:57 2023 +0100
pin SCons to fix safety tests
commit 6585cae978cf738d0077ac6bf1d3d4e61ca813b1
Author: AlexandreSato <66435071+AlexandreSato@users.noreply.github.com>
Date: Thu Mar 16 01:19:05 2023 -0300
safety replay: update steer value getter (#1273)
* toyota torque on toyota for safety replay
* Honda torque on Honda for safety replay
* Chrysler torque on Chrysler for safety replay
* Subaru torque on Subaru for safety replay
* fix
* Honda is Big Endian!
* Update helpers.py
* we already do this every where
* Update tests/safety_replay/helpers.py
* Update tests/safety_replay/helpers.py
* Update tests/safety_replay/helpers.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
commit 09ad59489e6e342bd8f042c0076219a0d7ab33b6
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 14 21:48:42 2023 -0700
tres: adjust siren volume (#1290)
Co-authored-by: Comma Device <device@comma.ai>
commit 75792fb25591f55b04a4ab4c87d305dac4f37d2c
Author: Igor Biletskyy <briskspirit@users.noreply.github.com>
Date: Tue Mar 14 14:49:39 2023 -0700
Fix different ADC scales (#1288)
* different ADC scales
* add HITL
* we had it, remove
commit 0afee2e0ff5c8c07b27e7c1d554574e4f701d46b
Author: Vincent Wright <vincentw@kmwperformance.com>
Date: Mon Mar 13 20:24:02 2023 -0400
Raise max steer limits for Ram DT (#1284)
* Raise max steer limits for Ram DT
* Update test_chrysler.py
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit f674084db5c10e09c22deda53be0d54a126a47d3
Author: martinl <martin@mlp.ee>
Date: Tue Mar 14 01:21:43 2023 +0200
MacOS: use gcc-12 for building tests (#1241)
* MacOS: use gcc-12 for building tests
* Update README.md
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit 3a5bbc6f201714e3fabda9629cedebc279282b15
Author: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Date: Mon Mar 13 16:36:41 2023 -0400
VW PQ: Corrected message name for ACC_GRA_Anzeige (#1286)
commit b231281c8b2c79c46892576dee4c8a56d5e0b2d2
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 7 20:12:23 2023 -0800
python: check SPI response length (#1280)
* python: check SPI response length
* fix read bytes
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 79210e8c2b8dbddda474cafd68d7ee0c8d0e4a40
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 7 15:18:11 2023 -0800
faster timeout for initial connect
commit 2de714011715618255972135f4ea5aab585a16f4
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 7 14:55:15 2023 -0800
SPI support in bootstub (#1227)
* always build spi
* no dos for now
* spi gpio init
* detect bootstub
* cleanup
* revert that
* move fx stuff
* fix linter
* set erase timeout
* fix types
* cleanup
---------
Co-authored-by: Comma Device <device@comma.ai>
commit deaad254d9ae75c1b9c0b28ced14d2c4bfc903ca
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 7 14:44:10 2023 -0800
python: non-zero default timeout (#1279)
* non-zero default timeout
* respect timeout in spi
commit df7952ec136f1a54ed83fe62d3d44bed6c93d202
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Mar 7 13:47:55 2023 -0800
python: add helper to check if up to date (#1269)
* python: add helper to check if up to date
* current
* handle is always basehandle
* update that
* Update __init__.py
---------
Co-authored-by: Bruce Wayne <batman@workstation-production.internal>
commit 544cf2ba825f7658a57c022137dab1fbf320a2f4
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Mar 6 22:26:56 2023 -0800
bootstub: add hw type endpoint (#1278)
commit efb36197bb5a39b516f9ffd85daea5037b7d0c0f
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Mar 6 21:52:08 2023 -0800
PandaDFU: SPI support (#1270)
* PandaDFU: SPI support
* get mcu type
* program bootstub
* little cleanup
* more cleanup
* connect by dfu serial
* time to remove that
* none
* fix linter
* little more
* catch
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 18230831f311a553ef64e55c1f418cb155eb3d7d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Mar 6 09:24:00 2023 -0800
PandaDFU: abstract out USB comms (#1274)
* wip
* revert that
* split list + connect
* some more
* mypy fix
* add clear status back
* rename
* cleanup
* cleaner mypy fix
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 946f952aa7fd84b5fad7608486efa84ff70e7b5b
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Mar 5 20:19:27 2023 -0800
DFU HITL tests (#1276)
* DFU HITL tests
* fix + types
* fix
* clear first
commit e0e754de2c7fdbf943dd02db203b7bb40bf3e9b5
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Mar 3 20:48:04 2023 -0800
safety replay: make Ford work (#1272)
* make replay work for ford
* revert debugging stuff
* clean that up
commit f7ba061279e2232648cd49c755001686061e2a60
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Mar 1 19:17:40 2023 -0800
Ford: test quality flags (#1266)
* adeeb
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* check checksum
* think pylint won't like this
* complete test
* do this
* no need
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit cb0cbf10d7bb157073d597e5c6bebbb72ddaeba5
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Feb 24 23:03:21 2023 -0800
Ford: set quality flags, checksum in safety tests (#1265)
set quality flags, checksum
commit 8bb62cf2268d95190750848aa173f38c7063a2be
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Feb 24 22:54:51 2023 -0800
Ford: check quality flag (#1264)
* quality flag support
* add NULL to other safety modes
* add to safety helpers debug print
* comment
* rename to quality_flag and add comment
commit a5ddde5d20c72edb0770f237ff4198e82d902cf4
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Feb 24 19:44:37 2023 -0800
Ford: check checksums (#1263)
* add signal names
* add checksum for BrakeSysFeatures
* add yaw data
* order
* misra
commit 384211eb130c8e6e6bd0b01c7d5b2b6c63caca88
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Feb 24 17:10:42 2023 -0800
Ford: check counter for yaw rate (#1262)
add yaw rate
commit f07309f74bf1bc7643d7f96459d9ff54564e5e46
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Feb 24 16:51:10 2023 -0800
Ford: set vehicle speed and check counter (#1261)
* set vehicle speed and check counter
* organize
* fix
* and test it properly
* fix horrible bug :( test_models now passes!
commit 1923b1418933e464ff7460a3e0a05d63aad0d53b
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Fri Feb 24 16:59:58 2023 +0100
RTC: increase LSE drive strength on H7 (#1252)
* higher LSE drive strength
* split out init per chip type
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 26ae1599bad265e4cb672b136897b5b72b6817e7
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Feb 23 21:09:48 2023 -0800
safety tests: refactor for cars with standstill bits (#1259)
* need this
* clean up
* pass on _speed_msg
commit ff39bc472dba46df92ddf75e8bf9a262f393bf31
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Feb 22 20:05:33 2023 -0800
Angle control safety: match openpilot limits (#1254)
* make limits match OP
* make tesla match too
* fudge speed
* we reason
* needs to be negative
commit a99f85dc8cf2223cb5c20113e7fab2e882c6c54f
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Feb 22 19:46:07 2023 -0800
Nissan: use averaged left and right wheel speeds (#1255)
* average left and right for a more accurate speed
* fix
* fix (again)
commit d076e9fb75501632b11fe50ca0787811db6aa715
Author: Comma Device <device@comma.ai>
Date: Wed Feb 22 15:49:11 2023 +0000
fix register divergent
commit 9fe24bd3683377146b04c68ab94d0935f0bd9d78
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Feb 21 15:34:09 2023 -0800
Revert "GM: update steering limits (#1239)" (#1248)
This reverts commit 0d2ee009218009173f26c73a16aefa12dd169de8.
commit d2c2d5f926537a132a253277998ef350fe866d27
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Mon Feb 20 13:47:35 2023 +0100
Fix short pulse of relay drive after reset (#1244)
fix order of gpio init
Co-authored-by: Comma Device <device@comma.ai>
commit 0d2ee009218009173f26c73a16aefa12dd169de8
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Feb 14 12:55:26 2023 -0800
GM: update steering limits (#1239)
* lower steer down val, increase allowance
* fix test fail
---------
Co-authored-by: nuwandavek <vivekaithal44@gmail.com>
commit d6af117c6297c9594e0ce0a747a3de2f271b3368
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Tue Feb 14 12:16:15 2023 +0100
Microsecond timer fix (#1236)
* add microsecond timer readout
* add CI test
* fix
commit 14051f9ce3c9cbaf7044c81c9902dd0f1cea3980
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Feb 13 14:13:40 2023 -0800
Chrysler: revert rate limit increase (#1240)
* Revert "Chrysler: add flag for alternate steer limits (#1238)"
This reverts commit d15250cb1454292c6f1217c79642b9ffd93e7595.
* Revert "Chrysler: increase torque rate limits (#985)"
This reverts commit ae051c94a393550ab8d70c594fc9dfb49bc9aed8.
commit 17450b277dadde7c53b7100601f7c9db40ee5fc3
Author: Shane Smiskol <shane@smiskol.com>
Date: Sat Feb 11 12:25:13 2023 -0800
Same mypy checks as openpilot (#1233)
* no specific revision for mypy
* bump to ~OP version
* same warnings as openpilot
* ignore
* fix
* rm that
* switch to ignore so mypy lets us know when it's fixed
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit d15250cb1454292c6f1217c79642b9ffd93e7595
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Fri Feb 10 22:20:50 2023 -0800
Chrysler: add flag for alternate steer limits (#1238)
commit 796d771912ef84a5f245d32b7dcfa9aa303061a3
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Wed Feb 8 16:01:14 2023 +0100
Enable control over the fan on C3 while still in the bootloader (#720)
* GPIO control over the fan from ABL
* fixes
* leave this todo
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 7d27eb10fb32095e73f60c59a123cae08cc53719
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Feb 7 23:33:51 2023 -0800
GM: adjust steering rate limits for slower message rate (#1235)
* Adjust GM steering limits for 50Hz -> 33Hz change
* fix test
commit 82151aaffefbb460887d09f4f5e29092d3b669ba
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Feb 7 20:02:06 2023 -0800
usb handle: ignore types (#1234)
ignore types
commit 0f964c6db3a0c1d30b8fd3ccc3fe4a91a48477e1
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Feb 2 23:02:03 2023 -0800
Ford: lateral motion control safety (#1228)
* assert the other signals are zeroed
* add to tja function
* fix misra
* test
* should tx
* ?
* rm line
* up here
* Update tests/safety/test_ford.py
* faster
* adjust round
commit 6ec0c80754cffab078001c4b73b313abbaf38629
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Jan 28 16:01:54 2023 -0800
python: common base handle for SPI + USB (#1231)
* base handle
* usb handle
* rm
* more types
commit e7f36a2992b353d7d66fbb697d166d4de8718c99
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Jan 28 14:41:52 2023 -0800
python: assume F4 MCU for bootstubs without bcdDevice set (#1229)
* python: assume F4 MCU for bootstubs without bcdDevice set
* cleanup
commit 6ae5212d6a796f87ef612996f8f98a8b8aa4222f
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Jan 28 00:32:07 2023 -0800
python lib: add SPI bootloader support (#1224)
* talk to spi bootloader
* flashing bootstub
* reset
* get mcu type
* little more
* pull out low level panda comms
* lint
* program app
---------
Co-authored-by: Comma Device <device@comma.ai>
commit 76d0459182d544d17c86d8b352e9cc1c26035f4d
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Jan 26 20:54:11 2023 -0800
cleanup MCU definitions (#1226)
* cleanup MCU definitions
* rename
* enum
* enum
* fix that
commit 33e576214d4fa437b6a4b0f87ac36fa9d87e63ea
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Thu Jan 26 18:06:02 2023 +0100
Tres: enable IR power irregardless of fan state (#1225)
* enable IR power irregardless of fan
* fix misra
Co-authored-by: Comma Device <device@comma.ai>
commit ae051c94a393550ab8d70c594fc9dfb49bc9aed8
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Jan 25 18:51:36 2023 -0800
Chrysler: increase torque rate limits (#985)
commit 687676be4025d9caf9520be89cb328d6a3cc3e10
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Tue Jan 24 13:50:51 2023 +0100
Add timeout to spi driver (#1223)
add timeout to spi driver
Co-authored-by: Comma Device <device@comma.ai>
commit 9b23622e91a2cc39a2218c387ed9fe4d1adb80d0
Author: Igor Biletksyy <bs@privacy.im>
Date: Mon Jan 23 17:23:33 2023 -0800
RP: pull USB_EN up
commit 0535f5f779ff6e989737d6384d3200a333426ad1
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Mon Jan 23 15:05:16 2023 -0800
small HITL test speedup (#1222)
* small speedup
* cleanup
* parallel connect
* little more
* less flaky
* update number of pandas
Co-authored-by: Bruce Wayne <batman@comma.ai>
commit 20365336705b33e914e53373e4e043340569deef
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Jan 22 21:49:14 2023 -0800
python: show SPI pandas in list (#1216)
* refactor connect
* spi list
* add back bcd
* couple fixes
* fix
Co-authored-by: Comma Device <device@comma.ai>
commit bf3791bdf255a6a0df44772ac4918eea53012766
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Jan 22 16:47:59 2023 -0800
CI: speedup CAN FD tests (#1221)
speedup canfd
Co-authored-by: Bruce Wayne <batman@comma.ai>
commit 97ad63b58640ff02277c6f7122f1d593a23e285a
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Jan 22 16:20:35 2023 -0800
CI: faster and more reliable HW reset (#1220)
* CI: faster and more reliable HW reset
* little more speed
* cleanup
Co-authored-by: Bruce Wayne <batman@comma.ai>
commit 4750449f3cc41e2dc8141b4818025c5c538dad17
Author: Igor Biletskyy <briskspirit@users.noreply.github.com>
Date: Thu Jan 19 17:07:50 2023 -0800
RP: obsolete USB load switch (#1219)
commit 3743b2de5136debc384409b09d06a761a62ee086
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Jan 18 16:31:51 2023 -0800
chiplet: move OBD_SBU_RELAY2 to PA3 (#1217)
Co-authored-by: Igor Biletksyy <bs@privacy.im>
commit 60cf9e9d224f6f0fcf680e7984952bd80afd2ec4
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Jan 18 14:32:25 2023 -0800
Revert "chiplet: move OBD_SBU_RELAY2 to PA3"
This reverts commit a0bd6bb21adcf848d47501bdb37714032ccca966.
commit a0bd6bb21adcf848d47501bdb37714032ccca966
Author: Igor Biletksyy <bs@privacy.im>
Date: Tue Jan 17 16:27:00 2023 -0800
chiplet: move OBD_SBU_RELAY2 to PA3
commit 0e5a2a47da6250e7a805eb31cce065f03c660352
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Jan 15 23:51:25 2023 -0800
python lib: print() -> logging (#1215)
* python lib: print() -> logging
* fstrings are fine
commit 3048760737a7b806d34e096e2111bb34b5af1393
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Jan 15 23:30:24 2023 -0800
SPI: connect by serial/UID (#1213)
* SPI: connect by serial/UID
* cleanup
* not everyone can have spi
* fix that
* move that
* mypy fix
Co-authored-by: Comma Device <device@comma.ai>
commit b8693da342c87da9f5b925726f296a2c7ab57c91
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sun Jan 15 20:13:26 2023 -0800
add comms handler to get MCU UID (#1212)
* cleanup first
* get uid
* add to bootstub and test
* fix pedal
* match that
Co-authored-by: Comma Device <device@comma.ai>
commit fa678e28fca7e017f8233ffc8b53096e3f7d8514
Author: Willem Melching <willem.melching@gmail.com>
Date: Sun Jan 15 21:51:22 2023 +0100
MacOS: no spidev package (#1211)
commit e83b2189c148499b8ba430433886791217f3389a
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Sat Jan 14 23:32:17 2023 -0800
lock spi device during transfers (#1207)
commit bdf39a451ed983417a73724e40b9aca944a1f629
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Jan 13 16:17:20 2023 -0800
Panda: context manager support (#1209)
* add __enter__ & __exit__ to Panda
* some examples
* another example
* even more
* use it here too
commit 520b9f1a8ee06789abaf10742633e34033af9ee6
Author: Cameron Clough <cameronjclough@gmail.com>
Date: Fri Jan 13 15:24:25 2023 -0800
examples: choose panda for fw query (#1076)
* examples: choose panda for fw query
* add type names
* add types and names to lists
* cleanup
* better output
* exit code
* dict
* delete
* get_type returns a bytearray
* simplify (okay to rely on Panda for this error catching)
* finish up
* not required for our use case
* clean up
* revert
Co-authored-by: Shane Smiskol <shane@smiskol.com>
commit 6f26866245cbe733130110fce93c26c81e8ef331
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Jan 13 15:20:42 2023 -0800
query_fw_versions: add arg to not multiplex bus 1 to OBD-II port (#1210)
* add arg to not multiplex (useful for auxpanda)
* formatting
* consistent quotes
commit 11d90f9e78b1c070e44e02d5d8c2b18790617324
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Fri Jan 13 10:59:58 2023 -0800
No more magic for the can chunks (#1191)
* no more magic
* bump version
* no need for this
* comment cleanup
* add comms_can_reset tests
* we can't ensure this for compatibility reasons
* add CANPacket_t checksum
commit 0b3b9060365739eeeddb1528cfe4018fec4efe7a
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Jan 10 22:00:20 2023 -0800
VW: match openpilot standstill check (#1064)
* VW: match openpilot standstill check
* fixes
* check > 0
* fix comments
* misra
* better
commit 744b21ef697b1716a03458801c08d5b5d1f3e2af
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Tue Jan 10 15:09:51 2023 -0800
Bring back green led mode + fix small python lib bug (#1206)
bring back green led mode
Co-authored-by: Panda Provisioning <panda@comma.ai>
commit 8b513970c38138ef638fd78e07e686f76ba0c5ec
Author: Willem Melching <willem.melching@gmail.com>
Date: Tue Jan 10 02:27:46 2023 +0100
fix debug uart buffer size (#1204)
commit 3034180753f09987e5cf410d33ca3279873da33d
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Mon Jan 9 14:27:18 2023 -0800
Reset CAN ign when the specific message is not seen anymore (#1200)
commit 0b58cb9e3c4cb2a056d279dc4c508d8d3f9bbea7
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Dec 20 23:05:04 2022 -0800
lower spi ack timeout
commit 5486eb38458faa3df6b8c4f5d4f0ca35f8c63048
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Dec 20 22:07:24 2022 -0800
python lib: add SPI ACK timeout (#1199)
* python lib: add SPI ACK timeout
* fix that
Co-authored-by: Comma Device <device@comma.ai>
commit 345147fe2bc3a06c44709426f9fcd298588b9fe4
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Dec 15 15:50:15 2022 -0800
tests: clean up abstract methods (#1196)
* don't need to redefine _torque_cmd_msg in abstract subclasses
* fix
* pylint has a bug?
* test pylint
* clean up
commit eed75e72328438ddc4e7afe52067f48259f183c2
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Dec 15 15:30:21 2022 -0800
Bump opendbc ref and update pylint (#1197)
* Update opendbc ref
* fix linting
* fix linting
* bump opendbc ref and pylint to fix import error bug
* ignore unspecified-encoding (openpilot does this)
* this will fail until openpilot is bumped
* bump openpilot
* wait... this works now?!
* bump opendbc to master
commit 6ba9afc33edc92c943509c266fb81c8cddf61202
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Wed Dec 14 16:12:09 2022 +0100
H7 clock source (#1194)
it's literally the same everything
Co-authored-by: Comma Device <device@comma.ai>
commit 1d732d4747ea81c199906e9f1fc620911fb8add0
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Wed Dec 14 15:30:04 2022 +0100
F4: Cleanup clock src, second try (#1193)
* F4: cleanup clock source
* little more
* void
* restore the timer setup
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
commit d1d1f8a22d0bd8174e9a7710ca9d91d2a92830ce
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Wed Dec 14 11:25:54 2022 +0100
Fake siren (#1192)
* DAC POC
* change freq
* some cleanup
* wip: cleaning up and trying to use DMA
* no clue why this doesn't work
* this works
* wip multi-master i2c for fake siren
* cleanup and some more i2c stuff
* seems more stable
* retry disabling and cleanup force siren
* fix misra violations
* not needed
* messed up rebase
Co-authored-by: Comma Device <device@comma.ai>
commit 9e5c28e568a1efe4bac340b48b3c16aafc82e84c
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Tue Dec 13 20:21:04 2022 -0800
safety replay updates for CAN-FD
commit d375ce64217a9cc489ae28fac0f8123111c18497
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Dec 8 16:14:22 2022 -0800
jenkins updates for new master
commit 93ecd31d3d5f94d03fd314e2765f45c467bba731
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Dec 7 22:23:41 2022 -0800
don't clog up jenkins build queue
commit 4edd1a602131ec2f09a604a4bd28e7d00e334458
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Fri Dec 2 23:34:06 2022 -0800
Hyundai: alt steering limits (#1186)
* Hyundai: alt steering limits
* parans
commit a6d0765b698e37e223616d21b59599aef0a67588
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Dec 2 16:45:23 2022 -0800
safety: common angle checks (#1182)
* common angle checks
* clean up
* clean up check and add comments
* readable
* ints
* tests draft
* clean up
* comment
* pylint exception
* clean up
* duplicate
commit 6e8a4fcc380de539be94b5da7a7d344ea05dca1d
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Dec 2 16:05:35 2022 -0800
safety tests: common angle tests (#1185)
* basic formatting
* common tests
* assert truthfulness
* ignore single pylint exception
* wya too many lines
commit 616450c525a7c1ef508f70f30e29547a606139aa
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Thu Dec 1 20:04:30 2022 -0800
tres bootkick (#1183)
* tres: bootkick
* replace usb enum
Co-authored-by: Comma Device <device@comma.ai>
commit 288e14cde904a5755ebb32b0853631ac7fbf5968
Author: Robbe Derks <robbe.derks@gmail.com>
Date: Thu Dec 1 08:38:00 2022 +0100
Simple CAN chunking (#1011)
* simple chunking
* make pylint happy
* misra happy?
* good practice anyways since we cast to a uint32_t later
* fix bug dropping packets
* minor fixes + prepare for shared lib testing
* working library now
* first queue test
* can send test
* fix running in github actions?
* add big rx test and fix it
* don't complain about empty buffers
* disable for now
* comment
* test runs
* some cleanup
* merge those
* test works
* rm that
* comment
* proper logging
* makes things too slow
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
commit 88b30e1a8487381b171b9e8f04900d088c3ac5a1
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date: Wed Nov 30 22:12:28 2022 -0800
CAN comms test (#1181)
* CAN comms test
* remove those
* cleanup
* little more
commit b238d41979970b52f9a2edb07489989f926311d1
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Nov 30 22:09:13 2022 -0800
safet…
Edison-CBS
pushed a commit
to Edison-CBS/panda
that referenced
this pull request
Jul 20, 2023
* what about * actually this is what we want * more explicit about this condition * frame type * add enum * use in func
sshane
added a commit
that referenced
this pull request
Aug 26, 2023
sshane
added a commit
that referenced
this pull request
Aug 26, 2023
return if updated reverts some of #1314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.