H7: CAN core reset on no ACK and high transmit error counter #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issues so far driving around in the EV6, but do we have a reliable way to reproduce this? If not, we should be able to repro by running fingerprinting in a loop and confirm it never fails now. |
|
Out of 100 fingerprint attempts with this branch, all succeeded (had no dropped frames), while only 14 of 100 passed on panda master. |
|
How exactly does this fix the fingerprinting issue? Just recover faster when multiplexing quickly? |
|
Recover faster and not to overload H7 with interrupts while trying to send frame on non-responsive bus (as we have auto retry on failed TX enabled) |
|
Let's write a good comment for this |
Edison-CBS
pushed a commit
to Edison-CBS/panda
that referenced
this pull request
Jul 21, 2023
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.