H7: fix GMLAN bitbang timer #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briskspirit
force-pushed
the
h7_fix_gmaln
branch
from
48156ff to
9d9c1d4
Compare
| @@ -119,6 +119,14 @@ def test_gmlan_bad_toggle(p): | |||
| assert comp_kbps_normal > (0.6 * SPEED_NORMAL) | |||
| assert comp_kbps_normal < (1.0 * SPEED_NORMAL) | |||
|
|
|||
| @pytest.mark.panda_expect_can_error | |||
| @pytest.mark.skip_panda_types(PandaGroup.GMLAN) | |||
| def test_gmlan_bitbang(p): | |||
There was a problem hiding this comment.
does this test catch the bug? it was pretty subtle
There was a problem hiding this comment.
bug was caused by wrong timer settings, so yes, was caught on RP everytime
| for _ in range(10): | ||
| p.can_send(0x10, b"data", 3) | ||
| time.sleep(0.1) | ||
| assert p.health()['gmlan_send_errs'] == 0 |
There was a problem hiding this comment.
also check the messages were sent on the loopback bus? do they get added there?
There was a problem hiding this comment.
don't think we ever forwarded those back, only rejected messages by safety mode.
|
Can we finish this? |
briskspirit
force-pushed
the
h7_fix_gmaln
branch
from
be923c8 to
7d49141
Compare
adeebshihadeh
added a commit
that referenced
this pull request
Nov 24, 2023
This reverts commit 5778c0a.
adeebshihadeh
added a commit
that referenced
this pull request
Nov 24, 2023
This reverts commit 5778c0a.
adeebshihadeh
added a commit
that referenced
this pull request
Nov 25, 2023
spektor56
added a commit
to spektor56/panda
that referenced
this pull request
Feb 7, 2024
This reverts commit 5778c0a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.