-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safety: assert that we use the steering req bit #1625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jnewb1
force-pushed
the
test-steer-bits
branch
from
August 31, 2023 23:08
e1e9d2f
to
2ef277a
Compare
just missing vw now |
Revert "can do this" This reverts commit 775abf8.
example failure catching a safety mode not setting steer_req ======================================================================
FAIL: test_steer_req_bit (__main__.TestGmCameraSafety.test_steer_req_bit)
Asserts all torque safety modes check the steering request bit
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/batman/openpilot/panda/tests/safety/common.py", line 300, in test_steer_req_bit
self.assertFalse(self._tx(self._torque_cmd_msg(self.MAX_TORQUE, 0)))
AssertionError: 1 is not false |
Changed the test to not modify the safety code. It's better not to add a variable that's not used anywhere in the safety, it's more prone to bugs (was missing from the init/reset function). |
sshane
reviewed
Sep 13, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
VW needs to control this bit for fault avoidance, any others?#1621