Hyundai CAN-FD: move HDA2 flag to common Hyundai safety #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sunnyhaibin
force-pushed
the
hkg-canfd-hda2-common
branch
from
a725baf
to
f33ee3a
Compare
sunnyhaibin
force-pushed
the
hkg-canfd-hda2-common
branch
from
f33ee3a
to
336d98c
Compare
sshane
reviewed
Sep 13, 2023
| bool hyundai_alt_limits = false; | ||
| uint8_t hyundai_last_button_interaction; // button messages since the user pressed an enable button | ||
|
|
||
| void hyundai_common_init(uint16_t param) { | ||
| hyundai_ev_gas_signal = GET_FLAG(param, HYUNDAI_PARAM_EV_GAS); | ||
| hyundai_hybrid_gas_signal = !hyundai_ev_gas_signal && GET_FLAG(param, HYUNDAI_PARAM_HYBRID_GAS); | ||
| hyundai_camera_scc = GET_FLAG(param, HYUNDAI_PARAM_CAMERA_SCC); | ||
| hyundai_canfd_hda2 = GET_FLAG(param, HYUNDAI_PARAM_CANFD_HDA2); |
There was a problem hiding this comment.
@sunnyhaibin can we just use one flag that describes if it's HDA2 or not? Has HDA2 ever existed on a purely CAN car?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite of