Subaru Pre-Global: Reverse driver torque signal for certain platforms #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should always add a test for new safety params. This wasn't caught because it's behind dashcamOnly, correct? |
| FLAGS = Panda.FLAG_SUBARU_PREGLOBAL_REVERSED_DRIVER_TORQUE | ||
|
|
||
| def _torque_driver_msg(self, torque): | ||
| return super()._torque_cmd_msg(-torque) |
There was a problem hiding this comment.
@jnewb1 the tests don't fail if you remove the sign from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves permanent steering faults when the user overrides steering and then releases the steering wheel. Thanks to @martinl for this fix from
subaru-community.Route ID:
b81cc3ea44acd372|2023-09-06--15-36-44Affected Platforms
2015-172018-2019Related