Volkswagen PQ sfety: check counter for ABS wheel speed message #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
changed the title
sshane
changed the title
|
Sorry, just saw this. It's okay to check the counter so far as I know. Not sure why this is closed, LMK if you want a PR for it. |
|
Just closed because I didn't want us spending any more cycles on dashcam'd cars. If you open a PR that just works, happy to merge. |
|
@jyoung8607 fyi, this just worked in the fuzzy carstate test when I opened it, so should be fine to open and run test_models on a few segments if you have any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a mismatch for commaai/openpilot#30443. @jyoung8607 any reason not to check counter? It was switched from a different message without a counter here, and this passes
test_models.py: #730