Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misra safety Check #1792

Closed
wants to merge 6 commits into from
Closed

Misra safety Check #1792

wants to merge 6 commits into from

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Jan 13, 2024

For first part of #1770,
add misra testing for safety files, enable misra-c2012-10.4

@adeebshihadeh
Copy link
Contributor

Is this still a draft? If not, I'm not sure what it's supposed to do. The test already checks the safety files. Let me know if you need clarification on the issue.

@bongbui321
Copy link
Contributor Author

bongbui321 commented Jan 13, 2024

Yeah, so right now one of the test in ./test_mutation.py is failing - it doesn't show on GHA(not sure why), but right now I'm going to enable misrac-10.4 so that that test would pass and then the first part (board/safety/* files) will be done

@bongbui321
Copy link
Contributor Author

@adeebshihadeh Okay it is ready for review now, enable misrac 10.4 and all the tests ./test_mutation.py pass now

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jan 13, 2024

@bongbui321 looks like there's a few different things going on in this PR that should be their own PR

  • editing test_misra.sh
  • adding new mutation test cases
  • enabling 10.4

I also formalized the bounty and wrote more instructions on enabling the rest of the MISRA rules: #1794. Total bounty for all the rules is 28*$50 = $1.4k. There's probably a bunch of low hanging fruit in there, along with some tricky ones.

@bongbui321 bongbui321 closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants