IsoTpMessage: extend timeout on first frame response #1933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try 2 of #1487 and #1610. Potentially fixes commaai/openpilot#32242
In short, this adds checks to first and single ISO-TP frame types. If you receive a first frame, the next message must be consecutive, or the new assertions in first and single are raised. You can receive as many single frames as you want without issue.
An additional rx length check is added to ensure that
rx_dat
isn't unset in the first frame hook (it previously acceptedm._isotp_rx_next(b'\x10\x08')
) which isn't a valid CAN frame size.This would cause the EPS to now successfully respond for:
297b4b460f361603/2023-06-14--16-55-16
297b4b460f361603/2023-06-14--16-48-52
297b4b460f361603/2023-06-21--04-09-15