-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subaru LKAS Angle safety model #2020
Open
bravochar
wants to merge
9
commits into
commaai:master
Choose a base branch
from
bravochar:ascent-2023
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
changed the title
WIP: LKAS Angle safety model
WIP: Subaru LKAS Angle safety model
Sep 13, 2024
Thanks for the PR, this has been on my todo list too long |
bravochar
changed the title
WIP: Subaru LKAS Angle safety model
Subaru LKAS Angle safety model
Sep 13, 2024
5 tasks
bravochar
force-pushed
the
ascent-2023
branch
from
November 23, 2024 14:48
f0ccd51
to
ad2c16d
Compare
bravochar
force-pushed
the
ascent-2023
branch
from
November 23, 2024 16:38
ad2c16d
to
6057481
Compare
I just rebased this so it's more up-to-date. My OpenDBC and OpenPilot PRs will be blocked until this is merged. Is there anything I'm missing here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer (3-camera) EyeSight systems need angle-based steering controls, which means new safety models. Most of this is lifted from jnewb1's abandoned branch.
The gist is that we're adding a new message and bus for the LKAS angle controls and using the Gen2 alt bus for most everything else.