GPIO: Explicitly casts constants to uint32_t
#2106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyhaibin
changed the title
uint32_tuint32_t
|
Why doesn't this fail on ours? |
That's the million dollar question. It started happening to us on the pipeline when adding a new header and one function call on Maybe something on the static analyzer made with an optimization or something decided to go that route. But this is very odd. However, from what I can tell, the warning is a valid one. So not sure why it wasn't flagged already when MISRA was introduced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly casts constants (
3Uandpin * 2U) touint32_tto prevent type promotion or mismatches.Noticed this MISRA violation when we were working on sunnypilot's panda using upstream's CI: https://github.com/sunnypilot/panda/actions/runs/12314225225/job/34369895304