Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subaru safety param for Impreza/Crosstrek 2020 #650

Closed
wants to merge 1 commit into from
Closed

Subaru safety param for Impreza/Crosstrek 2020 #650

wants to merge 1 commit into from

Conversation

martinl
Copy link
Contributor

@martinl martinl commented May 24, 2021 •
edited
Loading

This PR includes following changes:

  • safety parameter for checking Impreza/Crosstrek 2020+ lower steering torque limit
  • safety test covering the new safety parameter

This was referenced May 24, 2021
Merged
Merged
@adeebshihadeh
Copy link
Contributor

This PR is way too big to merge as is. Let's break this up into individual changes.

@martinl martinl changed the title Subaru safety update Subaru safety param for Impreza/Crosstrek 2020 May 25, 2021
@martinl
Copy link
Contributor Author

martinl commented May 25, 2021

I kept only Impreza/Crosstrek 2020 safety param, other changes get separate PR-s

@adeebshihadeh adeebshihadeh added the car safety vehicle-specific safety code label Jun 19, 2021
@martinl
Copy link
Contributor Author

martinl commented Oct 2, 2021

rebased to master

@martinl
Copy link
Contributor Author

martinl commented Dec 15, 2021

Lower torque check is not needed in panda safety since torque scale is same

@martinl martinl closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car safety vehicle-specific safety code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinl @adeebshihadeh