Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stock AEB message checks #825

Closed
wants to merge 4 commits into from

Conversation

jyoung8607
Copy link
Collaborator

@jyoung8607 jyoung8607 commented Jan 13, 2022

Verify stock AEB messages will be handled correctly per the requirement in #819.

  • Create per-safety-test list of stock AEB message tuples in the form (addr, target bus, optional source bus)
  • Ensure openpilot can't directly generate AEB messages to the target bus
  • If applicable, ensure the safety forward hook passes AEB messages from the source bus to the target bus
  • Add stock AEB tuples for VW MQB and VW PQ
  • Supersedable per-port for future OP AEB or situations like Toyota: add AEB message TX checks #820
  • Raise SkipTest (be a little loud but don't fail) if a port hasn't added an AEB tuple list or superseding test yet

@jyoung8607 jyoung8607 marked this pull request as draft January 13, 2022 22:29
@jyoung8607 jyoung8607 marked this pull request as ready for review January 14, 2022 00:41
@jyoung8607 jyoung8607 closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant