GM ignition: remove signal with noise and false positives #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue commaai/openpilot#23645
Verify on these cars:
e38a02cae1ef1e0c|2022-01-31--18-21-53
,e38a02cae1ef1e0c|2021-11-28--01-36-02
,e38a02cae1ef1e0c|2021-11-27--13-35-57
)Thanks to a route provided by @twilsonco (
e69bcbc2c84de4d2|2022-02-02--17-03-51
), this shows the preconditioning feature of a Chevy Volt being used, and has the old signal at 1 and the new signal at 0. This is the reason there's so many mismatches in the Chevy Volt comparisons, they're all false positives. Plot: https://imgur.com/a/Ed2MHWkA few plots: https://imgur.com/a/PEYtWm5
Checked data: