Runtime event store configuration #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lookup event store config at runtime. - Include Postgres `schema` in all database queries.
Closed
slashdotdash
force-pushed
the
feature/schema-prefix
branch
from
946a518 to
75aceb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an event store to be entirely configured at runtime. This requires associating the runtime config with the event store name and looking it up when needed. The restrictions on requiring compile-time configuration have been removed.
This pull request also changes the SQL statements to include the Postgres
schemain all database queries. Previously the Postgres search path was set to only include the event store schema when connecting to the database. This meant queries did not need to be prefixed with the schema. However to support shared database connection pools (#216) this approach is not appropriate since multiple event stores with different schemas need to share the same database connections.