Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil-pointer exception in SSH authentication #181

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix nil-pointer exception in SSH authentication #181

wants to merge 3 commits into from

Conversation

SimonBaeumer
Copy link
Member

@SimonBaeumer SimonBaeumer commented Nov 19, 2021 •
edited
Loading

ToDo

  • Reproduced issue
  • Investigate

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@SimonBaeumer SimonBaeumer mentioned this pull request Nov 19, 2021
Open
3 tasks
dylanhitt
dylanhitt previously approved these changes Nov 22, 2021
View reviewed changes
@dylanhitt
Copy link
Member

This looks good. I assume once #180 gets through a rebase should fix the failing pipeline.

Just a reminder I believe you will need to update the test case to adhere to the new function signature.

@dylanhitt dylanhitt self-requested a review November 22, 2021 14:23
@dylanhitt dylanhitt dismissed their stale review November 22, 2021 14:23

I didn't mean to approve just to comment.

@stdevel
Copy link

stdevel commented Mar 29, 2022

Any news on this? :)

@dylanhitt dylanhitt force-pushed the fix-nil-pointer-execption-ssh branch from cb90450 to e86cef6 Compare March 29, 2022 15:59
@dylanhitt dylanhitt force-pushed the fix-nil-pointer-execption-ssh branch 2 times, most recently from c29fb73 to 44421b7 Compare July 3, 2022 02:13
@dylanhitt
Copy link
Member

Hey @stdevel sorry for the wait I've been settling into a new position the past couple of months.

I'll probably try to pull this across early next week. So expect a 2.5.1 release.

Best

@dylanhitt dylanhitt force-pushed the fix-nil-pointer-execption-ssh branch from 44421b7 to 8fb23fc Compare July 3, 2022 02:32
@dylanhitt dylanhitt force-pushed the fix-nil-pointer-execption-ssh branch from 8fb23fc to e7f0bb8 Compare July 3, 2022 02:45
@stdevel
Copy link

stdevel commented Jul 3, 2022

Hi @dylanhitt,
no worries - thanks a lot for caring! I'll love to test the new release once it's available.

Best wishes,
Christian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanhitt dylanhitt Awaiting requested review from dylanhitt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonBaeumer @dylanhitt @stdevel