Clear waiting with disabled interrupt #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
indigodarkwolf
added a commit
to indigodarkwolf/box16
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking up documentation on how to use the
WAIinstruction, when I noticed that the emulator wasn't handling it correctly when the interrupt disable flag was set. Multiple sources I checked indicated that if the interrupt disable flag is set when callingWAI, then the interrupt handler won't be called on an IRQ, but theWAIwill end and continue execution from where it was. This PR moves the check for the interrupt disable flag frommain.ctocpu/fake6502.c, where it can still setwaitingto zero independent of the interrupt disable flag's status.