-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(deps): update dependency eslint-plugin-testing-library to v4 (#2160)
Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: tdeekens <tobias.deekens@commercetools.com>
- Loading branch information
1 parent
5961c01
commit 7734f69
Showing
42 changed files
with
823 additions
and
819 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@commercetools-frontend/application-components": patch | ||
"@commercetools-frontend/application-shell-connectors": patch | ||
"@commercetools-frontend/application-shell": patch | ||
"merchant-center-application-template-starter": patch | ||
--- | ||
|
||
Update dependency eslint-plugin-testing-library to v4 and use `screen` over assigning to `rendered` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 7 additions & 5 deletions
12
application-templates/starter/src/components/main-view/main-view.spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 4 additions & 3 deletions
7
packages/application-components/src/components/page-not-found/page-not-found.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
import React from 'react'; | ||
import { renderComponent } from '../../test-utils'; | ||
import { screen, renderComponent } from '../../test-utils'; | ||
import PageNotFound from './page-not-found'; | ||
|
||
describe('rendering', () => { | ||
it('should render help desk link', () => { | ||
const rendered = renderComponent(<PageNotFound />); | ||
expect(rendered.getByText('Help Desk')).toBeInTheDocument(); | ||
renderComponent(<PageNotFound />); | ||
|
||
expect(screen.getByText('Help Desk')).toBeInTheDocument(); | ||
}); | ||
}); |
12 changes: 7 additions & 5 deletions
12
packages/application-components/src/components/page-unauthorized/page-unauthorized.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,18 @@ | ||
import React from 'react'; | ||
import { renderComponent } from '../../test-utils'; | ||
import { screen, renderComponent } from '../../test-utils'; | ||
import PageUnauthorized from './page-unauthorized'; | ||
|
||
describe('rendering', () => { | ||
it('should render help desk link', () => { | ||
const rendered = renderComponent(<PageUnauthorized />); | ||
expect(rendered.getByText('Help Desk')).toBeInTheDocument(); | ||
renderComponent(<PageUnauthorized />); | ||
|
||
expect(screen.getByText('Help Desk')).toBeInTheDocument(); | ||
}); | ||
it('should render the title', () => { | ||
const rendered = renderComponent(<PageUnauthorized />); | ||
renderComponent(<PageUnauthorized />); | ||
|
||
expect( | ||
rendered.getByText('We could not find what you are looking for') | ||
screen.getByText('We could not find what you are looking for') | ||
).toBeInTheDocument(); | ||
}); | ||
}); |
Oops, something went wrong.
7734f69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs: