chore: update express and express-jwt packages (#2598)

* fix(express): migrate to express-jwt v7 * chore: update express * docs: changeset * chore: update lockfile
commercetools · May 9, 2022 · b151505 · b151505 · vercel · May 9, 2022
1 parent a5c26f2
commit b151505
Show file tree

Hide file tree

Showing 6 changed files with 235 additions and 71 deletions.
diff --git a/.changeset/late-suits-worry.md b/.changeset/late-suits-worry.md
@@ -0,0 +1,7 @@
+---
+'@commercetools-backend/express': patch
+'@commercetools-backend/loggers': patch
+'@commercetools-frontend/mc-dev-authentication': patch
+---
+
+Update `express` and `express-jwt` packages
diff --git a/packages-backend/express/package.json b/packages-backend/express/package.json
@@ -21,11 +21,13 @@
     "@babel/runtime": "^7.17.9",
     "@babel/runtime-corejs3": "^7.17.9",
     "@types/node": "16.11.26",
-    "express": "4.17.3",
-    "express-jwt": "6.1.1",
-    "jwks-rsa": "2.0.5"
+    "express": "4.18.1",
+    "express-jwt": "7.7.0",
+    "jwks-rsa": "2.1.1"
   },
   "devDependencies": {
+    "@types/express-unless": "^0.5.3",
+    "@types/jsonwebtoken": "^8.5.8",
     "jose": "2.0.5",
     "msw": "0.39.2"
   }

diff --git a/packages-backend/express/src/auth.ts b/packages-backend/express/src/auth.ts
@@ -5,7 +5,10 @@ import type {
 } from './types';
 
 import jwksRsa from 'jwks-rsa';
-import expressJwtMiddleware from 'express-jwt';
+import {
+  expressjwt as expressJwtMiddleware,
+  type GetVerificationKey,
+} from 'express-jwt';
 import {
   CLOUD_IDENTIFIERS,
   MC_API_URLS,
@@ -179,7 +182,7 @@ function createSessionAuthVerifier<Request extends TBaseRequest>(
           ...(options.jwks || {}),
           // This should be set by the middleware, no matter what.
           jwksUri: `${issuer}/.well-known/jwks.json`,
-        }),
+        }) as GetVerificationKey,
         requestProperty: decodedTokenKey,
         // Validate the audience and the issuer.
         audience,

diff --git a/packages-backend/loggers/package.json b/packages-backend/loggers/package.json
@@ -37,6 +37,6 @@
     "winston": "3.7.2"
   },
   "devDependencies": {
-    "express": "4.17.3"
+    "express": "4.18.1"
   }
 }
diff --git a/packages/mc-dev-authentication/package.json b/packages/mc-dev-authentication/package.json
@@ -30,7 +30,7 @@
   "devDependencies": {
     "@commercetools-frontend/application-config": "21.5.0",
     "@tsconfig/node14": "^1.0.1",
-    "express": "4.17.3"
+    "express": "4.18.1"
   },
   "engines": {
     "node": ">=14"