-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: reading
applicationId
value from custom application config (
#3147) * refactor: teamId use for local dev * chore: changeset * refactor: add teamId and applicationId to window.env.__DEVELOPMENT__ if teamId in the config
- Loading branch information
Showing
7 changed files
with
158 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@commercetools-frontend/application-config': patch | ||
--- | ||
|
||
Read `applicationId` from `env.production` rather than `env.development` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
packages/application-config/test/fixtures/config-oidc-with-team-id.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
{ | ||
"name": "avengers-app", | ||
"entryPointUriPath": "avengers", | ||
"cloudIdentifier": "gcp-eu", | ||
"env": { | ||
"development": { | ||
"initialProjectKey": "project-key", | ||
"teamId": "team-id" | ||
}, | ||
"production": { | ||
"applicationId": "app-id-123", | ||
"url": "https://avengers.app" | ||
} | ||
}, | ||
"oAuthScopes": { | ||
"view": ["view_orders", "view_states"], | ||
"manage": ["manage_orders"] | ||
}, | ||
"additionalOAuthScopes": [ | ||
{ | ||
"name": "movies", | ||
"view": ["view_products"], | ||
"manage": [] | ||
}, | ||
{ | ||
"name": "merch", | ||
"view": [], | ||
"manage": ["manage_channels"] | ||
} | ||
], | ||
"icon": "<svg><path fill=\"#000000\" /></svg>", | ||
"mainMenuLink": { | ||
"defaultLabel": "Avengers", | ||
"labelAllLocales": [], | ||
"permissions": [] | ||
}, | ||
"submenuLinks": [] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcfe233
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for merchant-center-application-kit ready!
✅ Preview
https://merchant-center-application-21elhnpjz-commercetools.vercel.app
Built with commit bcfe233.
This pull request is being automatically deployed with vercel-action