-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use compiled-data from uikit, expose compiled-data from appkit, use new data table #1685
Conversation
…kit, use new data table
🦋 Changeset is good to goLatest commit: 709ea03 We got this. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/jhw8n62f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
5fc7024
to
7c022d7
Compare
@@ -21,7 +21,7 @@ export default defineMessages({ | |||
description: | |||
'User does a bulk update but someone else has saved changes for that element', | |||
defaultMessage: | |||
'Sorry, but we were unable to save your changes as someone else made changes to this same resource while you were editing.', | |||
'Sorry, but we were unable to save your changes as someone else made changes to this same source while you were editing.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes simply reflect the values in the core.json
, so that by running the extract command we don't overwrite/change the values.
Alright, I think this is good to go now. It might be that the mc apps need to be updated to latest uikit + appkit + react-intl versions, to have everything working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳🤩😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes looks good.
Just one thing about exporting data. If you remember the discussion about exporting countries lists (at least the english countries data) from our |
Yep, we can add that as well |
29cf9e1
to
709ea03
Compare
No description provided.