Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency typescript to v4 #1695

Merged
merged 3 commits into from
Nov 23, 2020
Merged

chore(deps): update dependency typescript to v4 #1695

merged 3 commits into from
Nov 23, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 24, 2020 •
edited
Loading

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) 3.9.7 -> 4.1.2 age adoption passing confidence

Release Notes

Microsoft/TypeScript

v4.1.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v4.0.5

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v4.0.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v4.0.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the 🤖 Type: Dependencies Dependency updates or something similar label Aug 24, 2020
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2020 •
edited
Loading

🦋 Changeset detected

Latest commit: 9e26014

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@commercetools-backend/express Patch
@commercetools-frontend/application-shell Patch
merchant-center-application-template-starter Patch
playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 24, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/d5rpumfq1
✅ Preview: https://merchant-center-application-kit-git-renovate-typescript-4x.commercetools.now.sh

@emmenko
Copy link
Member

emmenko commented Aug 24, 2020

I suppose this requires some more work. Putting it on hold for now.

@emmenko emmenko marked this pull request as draft August 24, 2020 07:51
@tdeekens
Copy link
Contributor

I agree. Maybe wait some fix versions and for babel to catch up if needed.

@renovate renovate bot changed the title chore(deps): update dependency typescript to v4 Update dependency typescript to v4 Sep 9, 2020
@renovate renovate bot changed the title Update dependency typescript to v4 chore(deps): update dependency typescript to v4 Sep 9, 2020
@emmenko

This comment has been minimized.

Sign in to view
@emmenko emmenko changed the title chore(deps): update dependency typescript to v4 [Breaking] Update TypeScript to v4 Sep 11, 2020
@renovate renovate bot changed the title [Breaking] Update TypeScript to v4 chore(deps): update dependency typescript to v4 Sep 11, 2020
@vercel vercel bot temporarily deployed to Preview September 18, 2020 20:08 Inactive
@emmenko emmenko mentioned this pull request Sep 30, 2020
Closed
7 tasks
@emmenko emmenko mentioned this pull request Oct 26, 2020
Open
8 tasks
@vercel vercel bot temporarily deployed to Preview October 26, 2020 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview November 19, 2020 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview November 22, 2020 13:54 Inactive
tdeekens
tdeekens reviewed Nov 22, 2020
View reviewed changes
packages-backend/express/src/auth.ts
@@ -149,7 +152,7 @@ function createSessionAuthVerifier<
const requestUrlPath = request.originalUrl ?? request.url;
const audience = getConfiguredAudience(options, requestUrlPath);

return new Promise((resolve, reject) => {
return new Promise<void>((resolve, reject) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one surprised me in flopflip too.

@emmenko emmenko marked this pull request as ready for review November 23, 2020 08:14
@emmenko
Copy link
Member

emmenko commented Nov 23, 2020

I don't think we need to bump a major here.

@emmenko emmenko requested a review from a team November 23, 2020 08:15
tdeekens
tdeekens approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't think so. No exported types seem to change in an incompatible way. Had that in the flopper.

adnasa
adnasa approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@adnasa adnasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👌🏽

@vercel vercel bot temporarily deployed to Preview November 23, 2020 13:06 Inactive
@emmenko emmenko self-assigned this Nov 23, 2020
@emmenko emmenko merged commit e2d519f into master Nov 23, 2020
@emmenko emmenko deleted the renovate/typescript-4.x branch November 23, 2020 13:31
@ghost ghost mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnasa adnasa adnasa approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees

@emmenko emmenko

Labels
🤖 Type: Dependencies Dependency updates or something similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmenko @tdeekens @adnasa @renovate-bot