-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency typescript to v4 #1695
Conversation
🦋 Changeset detectedLatest commit: 9e26014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/d5rpumfq1 |
I suppose this requires some more work. Putting it on hold for now. |
I agree. Maybe wait some fix versions and for babel to catch up if needed. |
This comment has been minimized.
This comment has been minimized.
72fb182
to
1be870c
Compare
1be870c
to
1dccf72
Compare
1dccf72
to
dbe5262
Compare
@@ -149,7 +152,7 @@ function createSessionAuthVerifier< | |||
const requestUrlPath = request.originalUrl ?? request.url; | |||
const audience = getConfiguredAudience(options, requestUrlPath); | |||
|
|||
return new Promise((resolve, reject) => { | |||
return new Promise<void>((resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one surprised me in flopflip too.
I don't think we need to bump a major here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I don't think so. No exported types seem to change in an incompatible way. Had that in the flopper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done 👌🏽
This PR contains the following updates:
3.9.7
->4.1.2
Release Notes
Microsoft/TypeScript
v4.1.2
Compare Source
For release notes, check out the release announcement.
For the complete list of fixed issues, check out the
Downloads are available on:
v4.0.5
Compare Source
For release notes, check out the release announcement.
For the complete list of fixed issues, check out the
Downloads are available on:
v4.0.3
Compare Source
For release notes, check out the release announcement.
For the complete list of fixed issues, check out the
Downloads are available on:
v4.0.2
Compare Source
For release notes, check out the release announcement.
For the complete list of fixed issues, check out the
Downloads are available on:
Renovate configuration
📅 Schedule: "before 3am on Monday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.