Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency node-fetch to v2.6.1 [security] #1732

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 11, 2020

This PR contains the following updates:

Package Type Update Change
node-fetch dependencies patch 2.6.0 -> 2.6.1
node-fetch devDependencies patch 2.6.0 -> 2.6.1

GitHub Vulnerability Alerts

CVE-2020-15168

Impact

Node Fetch did not honor the size option after following a redirect, which means that when a content size was over the limit, a FetchError would never get thrown and the process would end without failure.

For most people, this fix will have a little or no impact. However, if you are relying on node-fetch to gate files above a size, the impact could be significant, for example: If you don't double-check the size of the data after fetch() has completed, your JS thread could get tied up doing work on a large file (DoS) and/or cost you money in computing.

Patches

We released patched versions for both stable and beta channels:

  • For v2: 2.6.1
  • For v3: 3.0.0-beta.9

Workarounds

None, it is strongly recommended to update as soon as possible.

For more information

If you have any questions or comments about this advisory:

  • Open an issue in node-fetch
  • Contact one of the core maintainers.

Release Notes

bitinn/node-fetch

v2.6.1

Compare Source

This is an important security release. It is strongly recommended to update as soon as possible.

See CHANGELOG for details.


Renovate configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the 🤖 Type: Dependencies Dependency updates or something similar label Sep 11, 2020
@vercel vercel bot temporarily deployed to Preview September 11, 2020 05:41 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2020

🦋 Changeset is good to go

Latest commit: cc48d74

We got this.

This PR includes changesets to release 8 packages
Name Type
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/application-shell Patch
playground Patch
@commercetools-frontend/mc-http-server Patch
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch
@commercetools-local/visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/aj01wug0t
✅ Preview: https://merchant-center-appli-git-renovate-npm-node-fetch-vulner-6429f1.commercetools.vercel.app

@vercel vercel bot temporarily deployed to Preview September 11, 2020 06:57 Inactive
@tdeekens tdeekens merged commit 1fdde03 into master Sep 11, 2020
@tdeekens tdeekens deleted the renovate/npm-node-fetch-vulnerability branch September 11, 2020 06:57
@ghost ghost mentioned this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 Type: Dependencies Dependency updates or something similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants