Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency mini-css-extract-plugin to v1 #1796

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 12, 2020

This PR contains the following updates:

Package Type Update Change
mini-css-extract-plugin dependencies major 0.12.0 -> 1.1.1

Release Notes

webpack-contrib/mini-css-extract-plugin

v1.1.1

Compare Source

v1.1.0

Compare Source

Features
  • added the attributes option (e8a2d5a)
  • added the insert option (a5f17c4)
Bug Fixes
1.0.0 (2020-10-09)
BREAKING CHANGE
  • minimum supported Node.js version is 10.13.0
  • the esModule option is true by default, you need to change const locals = require('./styles.css')/require('./styles.css') on import locals from './styles.css'/import './styles.css''
  • the moduleFilename option was removed in favor the filename option
  • the hmr option was removed, HMR will work automatically when HotModuleReplacement plugin used or webpack-dev-server with enabled the hot option
  • the reloadAll was removed
Features
  • the chunkFilename option can be a function for webpack@5
⚠ NOTICE

To avoid problems between mini-css-extract-plugin and style-loader because of changing the esModule option to true by default we strongly recommend upgrading style-loader to 2.0.0 version.

0.12.0 (2020-10-07)
Features
  • opt-in to transitive only side effects (webpack@5), no more empty JS chunks
0.11.3 (2020-10-02)
Bug Fixes
0.11.2 (2020-09-12)
Bug Fixes
0.11.1 (2020-09-08)
Bug Fixes
0.11.0 (2020-08-27)
Features
Bug Fixes
  • compatibility with webpack@5
0.10.0 (2020-08-10)
Features
Bug Fixes
0.9.0 (2019-12-20)
Features
0.8.2 (2019-12-17)
Bug Fixes
0.8.1 (2019-12-17)
Bug Fixes

v1.0.0

Compare Source


Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the 🤖 Type: Dependencies Dependency updates or something similar label Oct 12, 2020
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2020

⚠️ No Changeset found

Latest commit: e4fc80e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/5w2q370hs
✅ Preview: https://merchant-center-applica-git-renovate-mini-css-extract-pl-db62ab.commercetools.vercel.app

@vercel vercel bot temporarily deployed to Preview October 12, 2020 01:13 Inactive
@renovate renovate bot force-pushed the renovate/mini-css-extract-plugin-1.x branch from 211e39e to 6204dbe Compare October 19, 2020 17:14
@vercel vercel bot temporarily deployed to Preview October 19, 2020 17:14 Inactive
@renovate renovate bot force-pushed the renovate/mini-css-extract-plugin-1.x branch from 6204dbe to bef82a8 Compare October 20, 2020 15:30
@vercel vercel bot temporarily deployed to Preview October 20, 2020 15:31 Inactive
@renovate renovate bot force-pushed the renovate/mini-css-extract-plugin-1.x branch from bef82a8 to e4fc80e Compare October 21, 2020 07:20
@vercel vercel bot temporarily deployed to Preview October 21, 2020 07:20 Inactive
@pa3 pa3 self-requested a review October 22, 2020 14:36
Copy link
Contributor

@pa3 pa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking changes in mini-css-extract-plugin are:

  • minimum supported Node.js version is 10.13.0
  • the esModule option is true by default, you need to change const locals = require('./styles.css')/require('./styles.css') on import locals from './styles.css'/import './styles.css''
  • the moduleFilename option was removed in favor the filename option
  • the hmr option was removed, HMR will work automatically when HotModuleReplacement plugin used or webpack-dev-server with enabled the hot option
  • the reloadAll was removed

None of the above constitute a breaking change for app-kit. So we are fine to update.

@pa3 pa3 added the 🚀 Status: ship it Triggers an merge if rules match via bot label Oct 22, 2020
@kodiakhq kodiakhq bot merged commit a4d1d6d into master Oct 22, 2020
@kodiakhq kodiakhq bot deleted the renovate/mini-css-extract-plugin-1.x branch October 22, 2020 14:38
@emmenko
Copy link
Member

emmenko commented Oct 22, 2020

@pa3 you forgot to add a changeset.

You can create one and add it to the other PR #1797 (which also requires one). Thanks

@pa3
Copy link
Contributor

pa3 commented Oct 22, 2020

@emmenko oopsy, my bad. Thanks for keeping an eye on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Status: ship it Triggers an merge if rules match via bot 🤖 Type: Dependencies Dependency updates or something similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants