-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(quick access): wrong navigation when using product commands #1816
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/icbp64bgh |
🦋 Changeset detectedLatest commit: 7d75506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/application-shell/src/components/quick-access/create-commands.ts
Show resolved
Hide resolved
The build failed, not sure what to do. |
I restarted it. If it fails again maybe rebase over |
5c9114d
to
56c85df
Compare
This comment has been minimized.
This comment has been minimized.
You have to scroll up a bit in the CI logs. |
I fixed the issue and now there is one visual change, not related to my changes, that needs to be reviewed. |
Was just an SVG. Looks good. |
Summary
Fix wrong navigation when using Quick Access Product commands.
Description
Fix wrong navigation when using Quick Access Product commands.
Open Product List
andOpen Products
commands navigate the user to the old product list. Using them now navigate the user to the PIM list instead.Open Variant
command navigates the user to a "We could not find this Project" page because of the malformed URL. Using it now navigates the user to the variant details page.