Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quick access): wrong navigation when using product commands #1816

Merged
merged 5 commits into from
Oct 23, 2020

Conversation

ahmehri
Copy link
Member

@ahmehri ahmehri commented Oct 22, 2020

Summary

Fix wrong navigation when using Quick Access Product commands.

Description

Fix wrong navigation when using Quick Access Product commands.

  • Using Open Product List and Open Products commands navigate the user to the old product list. Using them now navigate the user to the PIM list instead.
  • Using Open Variant command navigates the user to a "We could not find this Project" page because of the malformed URL. Using it now navigates the user to the variant details page.

@vercel
Copy link

vercel bot commented Oct 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/icbp64bgh
✅ Preview: https://merchant-center-git-am-quick-access-products-wrong-navi-8dc11c.commercetools.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2020

🦋 Changeset detected

Latest commit: 7d75506

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@commercetools-frontend/application-shell Minor
merchant-center-application-template-starter Patch
playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ahmehri ahmehri requested a review from emmenko October 22, 2020 15:52
@ahmehri ahmehri self-assigned this Oct 22, 2020
@ahmehri ahmehri added 🐛 Type: Bug Something isn't working 🙏 Status: Dev Review Waiting for technical reviews labels Oct 22, 2020
@vercel vercel bot temporarily deployed to Preview October 22, 2020 16:14 Inactive
@ahmehri
Copy link
Member Author

ahmehri commented Oct 23, 2020

The build failed, not sure what to do.

@tdeekens
Copy link
Contributor

I restarted it. If it fails again maybe rebase over origin/master.

@ahmehri ahmehri force-pushed the am-quick-access-products-wrong-navigations branch from 5c9114d to 56c85df Compare October 23, 2020 09:17
@vercel vercel bot temporarily deployed to Preview October 23, 2020 09:17 Inactive
@ahmehri

This comment has been minimized.

@emmenko
Copy link
Member

emmenko commented Oct 23, 2020

No, this is the error

image

@emmenko
Copy link
Member

emmenko commented Oct 23, 2020

You have to scroll up a bit in the CI logs.

@vercel vercel bot temporarily deployed to Preview October 23, 2020 10:25 Inactive
@ahmehri
Copy link
Member Author

ahmehri commented Oct 23, 2020

I fixed the issue and now there is one visual change, not related to my changes, that needs to be reviewed.

@tdeekens
Copy link
Contributor

Was just an SVG. Looks good.

@ahmehri ahmehri added the 🚀 Status: ship it Triggers an merge if rules match via bot label Oct 23, 2020
@kodiakhq kodiakhq bot merged commit 323cf6b into master Oct 23, 2020
@kodiakhq kodiakhq bot deleted the am-quick-access-products-wrong-navigations branch October 23, 2020 13:16
@ghost ghost mentioned this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews 🚀 Status: ship it Triggers an merge if rules match via bot 🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants