Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql targets): added change history graphql target #1835

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

nbryant-commercetools
Copy link
Contributor

Summary:

As part of the work to integrate Change History with Merchant Center, a new GraphQL Target should be set up to be used for configuring a proxy for Change History API requests.

Solution:

  • Added new target value for change history
  • Adjusted tests

@nbryant-commercetools nbryant-commercetools added the 💅 Type: Enhancement Improves existing code label Oct 28, 2020
@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2020

🦋 Changeset detected

Latest commit: b34e93f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@commercetools-frontend/application-shell Patch
@commercetools-frontend/constants Patch
merchant-center-application-template-starter Patch
playground Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/l10n Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/b9em1d4yd
✅ Preview: https://merchant-center-application-kit-git-pangolin-529graphqltarget.commercetools.now.sh

Copy link
Contributor

@torihedden torihedden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second @stephsprinkle's suggestion for naming convention.

Co-authored-by: Stephanie Sprinkle <stephanie.sprinkle@commercetools.com>
@vercel vercel bot temporarily deployed to Preview October 28, 2020 19:03 Inactive
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nbryant-commercetools nbryant-commercetools added the 🚀 Status: ship it Triggers an merge if rules match via bot label Oct 28, 2020
@nbryant-commercetools nbryant-commercetools removed the request for review from wrsenn October 28, 2020 19:48
@kodiakhq kodiakhq bot merged commit 6059b9a into master Oct 28, 2020
@kodiakhq kodiakhq bot deleted the PANGOLIN-529_graphqlTarget branch October 28, 2020 19:49
@ghost ghost mentioned this pull request Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Status: ship it Triggers an merge if rules match via bot 💅 Type: Enhancement Improves existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants