-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(babel): to use import source for emotion and automatic runtime #1856
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/4ki5m6j3n |
🦋 Changeset detectedLatest commit: 339b8dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand we need to also remove @emotion/babel-preset-css-prop
and use babel-plugin-emotion
instead, right? 🧐
If you want to configure
runtime: "automatic"
just replace@emotion/babel-preset-css-prop
with@babel/preset-react
andbabel-plugin-emotion
.
You‘re right. Didn’t spot we use that. Will update this accordingly. |
This f73a411 is how I'd understand it. |
f73a411
to
27ed5c1
Compare
0fa0b57
to
339b8dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Summary
This pull request intends to fix the setup of the automatic runtime in combination with emotion.
Description
Emotion has recently added support for the automatic runtime. Then changed a bit again how it works
From this
To this
Ref: https://emotion.sh/docs/css-prop#babel-preset
So I guess we're lucky to have been sitting that change out quietly ;)