Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): regression, pass ROLLUP_BUILD env #1915

Merged
merged 2 commits into from
Dec 6, 2020

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Dec 5, 2020

Our babel preset uses a ROLLUP_BUILD env variable that we forgot to set when we moved to preconstruct.
It only affected prop types.

@vercel
Copy link

vercel bot commented Dec 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/picvx65ek
✅ Preview: https://merchant-center-application-kit-git-nm-fix-rollup-prop-types.commercetools.now.sh

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2020

🦋 Changeset detected

Latest commit: 90ededd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@commercetools-frontend/application-components Patch
@commercetools-frontend/react-notifications Patch
merchant-center-application-template-starter Patch
@commercetools-frontend/application-shell Patch
playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview December 5, 2020 16:56 Inactive
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥸

@emmenko emmenko merged commit 6819edc into master Dec 6, 2020
@emmenko emmenko deleted the nm-fix-rollup-prop-types branch December 6, 2020 21:18
@ghost ghost mentioned this pull request Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants