refactor: to use combine adapters with one #1971

tdeekens · 2021-01-11T13:45:04Z

Summary

This pull request experiments with the graphql-adapter and combine-adapters from @floplfip.

We don't have to use this functionality but I would like to propose it through this internally.

vercel · 2021-01-11T13:45:07Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/ckfmqm8mn
✅ Preview: https://merchant-center-application-kit-git-feat-add-graphql-adapter.commercetools.vercel.app

changeset-bot · 2021-01-11T13:45:07Z

🦋 Changeset detected

Latest commit: 9b37abb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@commercetools-backend/express	Patch
@commercetools-backend/loggers	Patch
@commercetools-frontend/actions-global	Patch
@commercetools-frontend/application-components	Patch
@commercetools-frontend/application-config	Patch
@commercetools-frontend/application-shell-connectors	Patch
@commercetools-frontend/application-shell	Patch
@commercetools-frontend/assets	Patch
@commercetools-frontend/babel-preset-mc-app	Patch
@commercetools-frontend/browser-history	Patch
@commercetools-frontend/constants	Patch
@commercetools-frontend/create-mc-app	Patch
@commercetools-frontend/cypress	Patch
@commercetools-frontend/jest-preset-mc-app	Patch
@commercetools-frontend/jest-stylelint-runner	Patch
@commercetools-frontend/l10n	Patch
@commercetools-frontend/mc-dev-authentication	Patch
@commercetools-frontend/mc-html-template	Patch
@commercetools-frontend/mc-scripts	Patch
@commercetools-frontend/notifications	Patch
@commercetools-frontend/permissions	Patch
@commercetools-frontend/react-notifications	Patch
@commercetools-frontend/sdk	Patch
@commercetools-frontend/sentry	Patch
merchant-center-application-template-starter	Patch
playground	Patch
@commercetools-local/visual-testing-app	Patch
@commercetools-website/components-playground	Patch
@commercetools-frontend/i18n	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

emmenko

Looks very promising. Thanks for pushing this 🤗

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

adnasa · 2021-01-12T14:31:10Z

I'm trying to review the implementation but I don't understand the application of graphql-adapter.
What do we get with this? 🤔

tdeekens · 2021-01-12T15:01:31Z

I'm trying to review the implementation but I don't understand the application of graphql-adapter.
What do we get with this? 🤔

The idea is to homogenise the internal use of feature flags. We also have a fe-chapter issue about the topic.

The status quo internally is that we have:

Long-lived feature configuration: e.g. if the dashboard is deployed to the given environment
Short-lived feature flags: e.g. if platform limits are enabled

Both are rightfully configured in different systems. 1. is in our k8s files as a ConfigMap. 2. is in LaunchDarkly.

Now for either system or type of flag we use a different "backing system". For 1. we use @flopflip for 2. we use a useFeatureStatus (as we call it). This evaluates if it's possible to migrate both to only use @flopflip. It would load both types of flags and exposes them both to the FE. With that we could throw away all code we have around useFeatureStatus and remove confusion when to use what system or library.

adnasa · 2021-01-12T15:03:44Z

aaah clear.
thanks for clarifying!

adnasa

Looks good overall. just a question

adnasa · 2021-01-12T15:23:28Z

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

 // This value is hard-coded here because we want to make sure that the
 // app uses our account of LD. The value is meant to be public, so there
 // is no need to be concerned about security.
 const ldClientSideIdProduction = '5979d95f6040390cd07b5e01';

+combineAdapters.combine([ldAdapter, graphqlAdapter]);
+
+const getRequestHeaders = (props: Props) =>


apologies if I confuse things.

the getRequestHeaders is supposedly called with adapterArgs.

Here, we accept props..

Where did props come from?
maybe this is related to why you had to // @ts-expect-error?

Thanks. That's a good catch!

ping me when you resolve it ;)

Sure. I am doing this on the side. So might take some time :)

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

emmenko

Nice, I like it. It's also much simpler now!

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

tdeekens · 2021-01-14T23:40:34Z

I think I am done on the @flopflip side. Type checks should also pass. Next would be experimenting with it internally.

tdeekens · 2021-01-15T00:05:28Z

So far so good

Need to fix 1-2 things in @flopflip I think how we can read these complex flag values now.

tdeekens · 2021-01-22T14:52:07Z

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

@@ -81,15 +81,10 @@ const parseFlags = (fetchedFlags: TFetchedFlags): TParsedHttpAdapterFlags =>
    ])
  );

-type TAdditionalEnvironmentProperties = {


I felt that anything that app-kit supports should be additional conceptually...

tdeekens · 2021-01-22T14:52:19Z

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

@@ -101,11 +96,11 @@ export const SetupFlopFlipProvider = (props: Props) => {
    [allMenuFeatureToggles.allFeatureToggles, props.flags]
  );
  React.useMemo(() => {


Simple code is good code I think.

packages/constants/src/constants.ts

adnasa · 2021-01-25T09:19:25Z

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx

@@ -143,7 +143,7 @@ export const SetupFlopFlipProvider = (props: Props) => {
          });

          return parseFlags(response.data);
-        }
+        },


emmenko

Thanks, looks good to me now. Don't forget to add the changeset.

tdeekens · 2021-01-25T14:21:59Z

Yup. I want to beta test this a bit more. So I'll not merge it for now. I need time for that.

tdeekens · 2021-01-26T13:15:56Z

Ok. I did extensive testing internally. This works very nicely. Anything left here @emmenko otherwise I can start integrating.

I will share details of my integrating testing internally.

emmenko

Looks good! Looking forward to see this in action 🚀

.changeset/dull-bees-obey.md

Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.de>

vercel bot temporarily deployed to Preview January 11, 2021 14:02 Inactive

tdeekens commented Jan 11, 2021

View reviewed changes

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx Outdated Show resolved Hide resolved

emmenko reviewed Jan 11, 2021

View reviewed changes

vercel bot temporarily deployed to Preview January 12, 2021 08:54 Inactive

adnasa reviewed Jan 12, 2021

View reviewed changes

vercel bot had a problem deploying to Preview January 13, 2021 12:33 Failure

vercel bot had a problem deploying to Preview January 14, 2021 08:45 Failure

tdeekens commented Jan 14, 2021

View reviewed changes

packages/application-shell/src/components/setup-flop-flip-provider/setup-flop-flip-provider.tsx Outdated Show resolved Hide resolved

emmenko reviewed Jan 14, 2021

View reviewed changes

tdeekens force-pushed the feat/add-graphql-adapter branch from 8b741ab to f8f7db5 Compare January 14, 2021 11:13

vercel bot had a problem deploying to Preview January 14, 2021 11:13 Failure

tdeekens force-pushed the feat/add-graphql-adapter branch from f8f7db5 to 56d45d4 Compare January 14, 2021 13:55

vercel bot had a problem deploying to Preview January 14, 2021 13:55 Failure

tdeekens force-pushed the feat/add-graphql-adapter branch from 56d45d4 to e56fea6 Compare January 14, 2021 14:12

vercel bot had a problem deploying to Preview January 14, 2021 14:12 Failure

vercel bot had a problem deploying to Preview January 14, 2021 14:57 Failure

tdeekens force-pushed the feat/add-graphql-adapter branch from ea7bb41 to 251790b Compare January 14, 2021 23:39

vercel bot temporarily deployed to Preview January 14, 2021 23:39 Inactive

tdeekens force-pushed the feat/add-graphql-adapter branch from 251790b to 8fef400 Compare January 14, 2021 23:55

vercel bot temporarily deployed to Preview January 14, 2021 23:55 Inactive

tdeekens force-pushed the feat/add-graphql-adapter branch from 8fef400 to 88e07f4 Compare January 20, 2021 14:03

vercel bot temporarily deployed to Preview January 20, 2021 14:03 Inactive

vercel bot temporarily deployed to Preview January 20, 2021 14:37 Inactive

vercel bot temporarily deployed to Preview January 22, 2021 14:51 Inactive

tdeekens commented Jan 22, 2021

View reviewed changes

tdeekens force-pushed the feat/add-graphql-adapter branch from cbe4626 to ea5d9d4 Compare January 22, 2021 14:54

vercel bot temporarily deployed to Preview January 22, 2021 15:00 Inactive

vercel bot temporarily deployed to Preview January 22, 2021 15:18 Inactive

tdeekens marked this pull request as ready for review January 22, 2021 15:19

tdeekens requested review from adnasa and emmenko January 22, 2021 15:19

adnasa approved these changes Jan 25, 2021

View reviewed changes

emmenko reviewed Jan 25, 2021

View reviewed changes

tdeekens added 7 commits January 26, 2021 13:56

refactor: to use combine adapters with one

0b35726

chore: update versions

5d0860d

chore: update deps

cc5dd28

fix: a comma can make a huge difference

478fe87

feat: add environment based flag for fetching

1e36b8f

refactor: simplify code

3ba1fe3

chore: sort things differently

60b0d12

tdeekens force-pushed the feat/add-graphql-adapter branch from dd941f6 to 60b0d12 Compare January 26, 2021 13:00

vercel bot temporarily deployed to Preview January 26, 2021 13:00 Inactive

Create dull-bees-obey.md

5a753f0

vercel bot temporarily deployed to Preview January 26, 2021 13:15 Inactive

tdeekens requested a review from emmenko January 26, 2021 13:16

emmenko approved these changes Jan 26, 2021

View reviewed changes

.changeset/dull-bees-obey.md Outdated Show resolved Hide resolved

Update .changeset/dull-bees-obey.md

9b37abb

Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.de>

vercel bot temporarily deployed to Preview January 26, 2021 15:22 Inactive

emmenko merged commit 3bf3299 into master Jan 26, 2021

emmenko deleted the feat/add-graphql-adapter branch January 26, 2021 16:01

ghost mentioned this pull request Jan 26, 2021

Version Packages #2001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: to use combine adapters with one #1971

refactor: to use combine adapters with one #1971

tdeekens commented Jan 11, 2021

vercel bot commented Jan 11, 2021 •

edited

Loading

changeset-bot bot commented Jan 11, 2021 •

edited

Loading

emmenko left a comment

adnasa commented Jan 12, 2021

tdeekens commented Jan 12, 2021

adnasa commented Jan 12, 2021

adnasa left a comment

adnasa Jan 12, 2021 •

edited

Loading

tdeekens Jan 12, 2021

adnasa Jan 13, 2021

tdeekens Jan 13, 2021

emmenko left a comment

tdeekens commented Jan 14, 2021

tdeekens commented Jan 15, 2021

tdeekens Jan 22, 2021

tdeekens Jan 22, 2021

adnasa Jan 25, 2021

emmenko left a comment

tdeekens commented Jan 25, 2021

tdeekens commented Jan 26, 2021 •

edited

Loading

emmenko left a comment

refactor: to use combine adapters with one #1971

refactor: to use combine adapters with one #1971

Conversation

tdeekens commented Jan 11, 2021

Summary

vercel bot commented Jan 11, 2021 • edited Loading

changeset-bot bot commented Jan 11, 2021 • edited Loading

🦋 Changeset detected

emmenko left a comment

Choose a reason for hiding this comment

adnasa commented Jan 12, 2021

tdeekens commented Jan 12, 2021

adnasa commented Jan 12, 2021

adnasa left a comment

Choose a reason for hiding this comment

adnasa Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

tdeekens Jan 12, 2021

Choose a reason for hiding this comment

adnasa Jan 13, 2021

Choose a reason for hiding this comment

tdeekens Jan 13, 2021

Choose a reason for hiding this comment

emmenko left a comment

Choose a reason for hiding this comment

tdeekens commented Jan 14, 2021

tdeekens commented Jan 15, 2021

tdeekens Jan 22, 2021

Choose a reason for hiding this comment

tdeekens Jan 22, 2021

Choose a reason for hiding this comment

adnasa Jan 25, 2021

Choose a reason for hiding this comment

emmenko left a comment

Choose a reason for hiding this comment

tdeekens commented Jan 25, 2021

tdeekens commented Jan 26, 2021 • edited Loading

emmenko left a comment

Choose a reason for hiding this comment

vercel bot commented Jan 11, 2021 •

edited

Loading

changeset-bot bot commented Jan 11, 2021 •

edited

Loading

adnasa Jan 12, 2021 •

edited

Loading

tdeekens commented Jan 26, 2021 •

edited

Loading